Add other missing parts of DiffEqBase

Author: MilesCranmer

ext/DynamicQuantitiesDiffEqBaseExt.jl

@@ -1,36 +1,22 @@
 module DynamicQuantitiesDiffEqBaseExt
 
-using DynamicQuantities: UnionAbstractQuantity, ustrip
+using DynamicQuantities: 
+    UnionAbstractQuantity, ustrip, QuantityArray
 
 import DiffEqBase
 
 DiffEqBase.value(x::UnionAbstractQuantity) = ustrip(x)
-DiffEqBase.recursive_length(u::UnionAbstractQuantity) = length(u)
-DiffEqBase.recursive_length(u::QuantityArray) = length(u)
-
-# @inline function DiffEqBase.UNITLESS_ABS2(x::UnionAbstractQuantity)
-#     abs(DiffEqBase.value(x))
-# end
-# function DiffEqBase.abs2_and_sum(x::DynamicQuantities.Quantity, y::Float64)
-#     reduce(Base.add_sum, DiffEqBase.value(x), init = zero(real(DiffEqBase.value(x)))) +
-#     reduce(Base.add_sum, y, init = zero(real(DiffEqBase.value(eltype(y)))))
-# end
-
-# Base.sign(x::DynamicQuantities.Quantity) = Base.sign(DiffEqBase.value(x))
-
-# function DiffEqBase.prob2dtmin(prob; use_end_time = true)
-#     DiffEqBase.prob2dtmin(prob.tspan, oneunit(first(prob.tspan)), use_end_time)
-# end
-
-# DiffEqBase.NAN_CHECK(x::DynamicQuantities.Quantity) = isnan(x)
-# Base.zero(x::Array{T}) where {T<:DynamicQuantities.Quantity} = zero.(x)
-
-# @inline function DiffEqBase.calculate_residuals(ũ, u₀, u₁, α, ρ, internalnorm, t)
-#     @. DiffEqBase.calculate_residuals(ũ, u₀, u₁, α, ρ, internalnorm, t)
-# end
-
-# f(u, p, t) = u / t;
-# problem = ODEProblem(f, [1.0u"km/s"], (0.0u"s", 1.0u"s"));
-# sol = solve(problem, Tsit5(), dt = 0.1u"s")
+DiffEqBase.recursive_length(u::UnionAbstractQuantity) = recursive_length(ustrip(u))
+DiffEqBase.recursive_length(u::QuantityArray) = recursive_length(ustrip(u))
+
+@inline function DiffEqBase.UNITLESS_ABS2(x::UnionAbstractQuantity)
+    abs2(ustrip(x))
+end
+function DiffEqBase.abs2_and_sum(x::UnionAbstractQuantity, y)
+    reduce(Base.add_sum, ustrip(x), init = zero(real(DiffEqBase.value(x)))) +
+        reduce(Base.add_sum, y, init = zero(real(DiffEqBase.value(eltype(y)))))
+end
+
+DiffEqBase.NAN_CHECK(x::UnionAbstractQuantity) = NAN_CHECK(ustrip(x))
 
 end

src/utils.jl

@@ -183,6 +183,7 @@ Base.zero(q::Q) where {Q<:UnionAbstractQuantity} = new_quantity(Q, zero(ustrip(q
 Base.zero(::AbstractDimensions) = error("There is no such thing as an additive identity for a `AbstractDimensions` object, as + is only defined for `UnionAbstractQuantity`.")
 Base.zero(::Type{<:UnionAbstractQuantity}) = error("Cannot create an additive identity for a `UnionAbstractQuantity` type, as the dimensions are unknown. Please use `zero(::UnionAbstractQuantity)` instead.")
 Base.zero(::Type{<:AbstractDimensions}) = error("There is no such thing as an additive identity for a `AbstractDimensions` type, as + is only defined for `UnionAbstractQuantity`.")
+Base.zero(x::Array{Q}) where {Q<:UnionAbstractQuantity} = zero.(x)
 
 # Dimensionful 1 (oneunit)
 Base.oneunit(q::Q) where {Q<:UnionAbstractQuantity} = new_quantity(Q, oneunit(ustrip(q)), dimension(q))