failing: londouble with different dtype

Author: SwayamInSync

quaddtype/numpy_quaddtype/src/dtype.c

@@ -57,7 +57,6 @@ new_quaddtype_instance(QuadBackendType backend)
     new->base.elsize = (backend == BACKEND_SLEEF) ? sizeof(Sleef_quad) : sizeof(long double);
     new->base.alignment = (backend == BACKEND_SLEEF) ? _Alignof(Sleef_quad) : _Alignof(long double);
     new->backend = backend;
-
     return new;
 }
 
@@ -73,7 +72,7 @@ common_instance(QuadPrecDTypeObject *dtype1, QuadPrecDTypeObject *dtype2)
 {
     if (dtype1->backend != dtype2->backend) {
         PyErr_SetString(PyExc_TypeError,
-                        "Cannot combine QuadPrecDType instances with different backends");
+                        "Cannot find common instance for QuadPrecDTypes with different backends");
         return NULL;
     }
     Py_INCREF(dtype1);
@@ -189,7 +188,8 @@ QuadPrecDType_new(PyTypeObject *NPY_UNUSED(cls), PyObject *args, PyObject *kwds)
         return NULL;
     }
 
-    return (PyObject *)new_quaddtype_instance(backend);
+    return (PyObject *)quadprec_discover_descriptor_from_pyobject(
+            &QuadPrecDType, (PyObject *)QuadPrecision_raw_new(backend));
 }
 
 static PyObject *
@@ -217,7 +217,7 @@ init_quadprec_dtype(void)
         return -1;
 
     PyArrayDTypeMeta_Spec QuadPrecDType_DTypeSpec = {
-            .flags = NPY_DT_NUMERIC,
+            .flags = NPY_DT_PARAMETRIC | NPY_DT_NUMERIC,
             .casts = casts,
             .typeobj = &QuadPrecision_Type,
             .slots = QuadPrecDType_Slots,

quaddtype/numpy_quaddtype/src/dtype.h

@@ -17,9 +17,11 @@ typedef struct {
 
 extern PyArray_DTypeMeta QuadPrecDType;
 
-QuadPrecDTypeObject * new_quaddtype_instance(QuadBackendType backend);
+QuadPrecDTypeObject *
+new_quaddtype_instance(QuadBackendType backend);
 
-int init_quadprec_dtype(void);
+int
+init_quadprec_dtype(void);
 
 #ifdef __cplusplus
 }

quaddtype/numpy_quaddtype/src/ops.hpp

@@ -376,7 +376,7 @@ quad_greaterequal(const Sleef_quad *a, const Sleef_quad *b)
 }
 
 // comparison quad functions
-typedef npy_bool (*cmp_londouble_def)(const long double *, const double *);
+typedef npy_bool (*cmp_londouble_def)(const long double *, const long double *);
 
 static inline npy_bool
 ld_equal(const long double *a, const long double *b)

quaddtype/numpy_quaddtype/src/quad_common.h

@@ -6,6 +6,7 @@ extern "C" {
 #endif
 
 typedef enum {
+    BACKEND_INVALID = -1,
     BACKEND_SLEEF,
     BACKEND_LONGDOUBLE
 } QuadBackendType;

quaddtype/numpy_quaddtype/src/quaddtype_main.c

@@ -11,7 +11,7 @@
 
 #include "scalar.h"
 #include "dtype.h"
-// #include "umath.h"
+#include "umath.h"
 #include "quad_common.h"
 
 static struct PyModuleDef moduledef = {
@@ -43,9 +43,9 @@ PyInit__quaddtype_main(void)
     if (PyModule_AddObject(m, "QuadPrecDType", (PyObject *)&QuadPrecDType) < 0)
         goto error;
 
-    // if (init_quad_umath() < 0) {
-    //     goto error;
-    // }
+    if (init_quad_umath() < 0) {
+        goto error;
+    }
 
     return m;