Skip to content

Commit 42d638f

Browse files
committed
PYTHON-5168 Adjust test_continuous_network_errors to be less flaky
1 parent 3287c15 commit 42d638f

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

test/asynchronous/test_client.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1847,20 +1847,20 @@ def server_description_count():
18471847
return i
18481848

18491849
gc.collect()
1850-
with client_knobs(min_heartbeat_interval=0.003):
1850+
with client_knobs(min_heartbeat_interval=0.002):
18511851
client = self.simple_client(
1852-
"invalid:27017", heartbeatFrequencyMS=3, serverSelectionTimeoutMS=150
1852+
"invalid:27017", heartbeatFrequencyMS=2, serverSelectionTimeoutMS=200
18531853
)
18541854
initial_count = server_description_count()
18551855
with self.assertRaises(ServerSelectionTimeoutError):
18561856
await client.test.test.find_one()
18571857
gc.collect()
18581858
final_count = server_description_count()
1859+
await client.close()
18591860
# If a bug like PYTHON-2433 is reintroduced then too many
18601861
# ServerDescriptions will be kept alive and this test will fail:
1861-
# AssertionError: 19 != 46 within 15 delta (27 difference)
1862-
# On Python 3.11 we seem to get more of a delta.
1863-
self.assertAlmostEqual(initial_count, final_count, delta=20)
1862+
# AssertionError: 11 != 47 within 20 delta (36 difference)
1863+
self.assertAlmostEqual(initial_count, final_count, delta=30)
18641864

18651865
@async_client_context.require_failCommand_fail_point
18661866
async def test_network_error_message(self):

test/test_client.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1804,20 +1804,20 @@ def server_description_count():
18041804
return i
18051805

18061806
gc.collect()
1807-
with client_knobs(min_heartbeat_interval=0.003):
1807+
with client_knobs(min_heartbeat_interval=0.002):
18081808
client = self.simple_client(
1809-
"invalid:27017", heartbeatFrequencyMS=3, serverSelectionTimeoutMS=150
1809+
"invalid:27017", heartbeatFrequencyMS=2, serverSelectionTimeoutMS=200
18101810
)
18111811
initial_count = server_description_count()
18121812
with self.assertRaises(ServerSelectionTimeoutError):
18131813
client.test.test.find_one()
18141814
gc.collect()
18151815
final_count = server_description_count()
1816+
client.close()
18161817
# If a bug like PYTHON-2433 is reintroduced then too many
18171818
# ServerDescriptions will be kept alive and this test will fail:
1818-
# AssertionError: 19 != 46 within 15 delta (27 difference)
1819-
# On Python 3.11 we seem to get more of a delta.
1820-
self.assertAlmostEqual(initial_count, final_count, delta=20)
1819+
# AssertionError: 11 != 47 within 20 delta (36 difference)
1820+
self.assertAlmostEqual(initial_count, final_count, delta=30)
18211821

18221822
@client_context.require_failCommand_fail_point
18231823
def test_network_error_message(self):

0 commit comments

Comments
 (0)