Skip to content

Commit 654fc76

Browse files
Oceania2018Oceania2018
committed
fix gradients parameters issue.
1 parent 99bd08b commit 654fc76

File tree

8 files changed

+29
-80
lines changed

8 files changed

+29
-80
lines changed

‎src/TensorFlowNET.Core/Gradients/array_grad.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ there will be a small number of performance regressions.*/
9696
new Tensor[] { non_neg_concat_dim, tf.constant(0) },
9797
new Tensor[] { tf.constant(1), tf.constant(-1) });
9898
var squeeze_sizes = array_ops.squeeze(slice);
99-
out_grads = gen_array_ops.split(grad, squeeze_sizes, (int)non_neg_concat_dim.Data<int>()[0]).ToList();
99+
out_grads = gen_array_ops.split(grad, squeeze_sizes, (int)non_neg_concat_dim).ToList();
100100
}
101101
else
102102
{

‎src/TensorFlowNET.Core/Gradients/gradients_util.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ public static Tensor[] _GradientsHelper(Tensor[] ys,
146146
string name1 = scope1;
147147
if (grad_fn != null)
148148
{
149-
in_grads = _MaybeCompile(grad_scope, op, out_grads[0].ToArray(), null, grad_fn);
149+
in_grads = _MaybeCompile(grad_scope, op, out_grads.Select(x => x[0]).ToArray(), null, grad_fn);
150150
_VerifyGeneratedGradients(in_grads, op);
151151
}
152152

@@ -333,7 +333,7 @@ private static List<List<Tensor>> _AggregatedGrads(Dictionary<string, List<List<
333333
throw new ValueError("_AggregatedGrads out_grad.Length == 0");
334334
}
335335

336-
out_grads[i] = out_grad;
336+
out_grads[i] = new List<Tensor> { out_grad[0] };
337337
}
338338
else
339339
{

‎src/TensorFlowNET.Core/Operations/Losses/losses_impl.py.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ public Tensor sparse_softmax_cross_entropy(Tensor labels,
141141
// Use static rank.
142142
var rank_diff = weights_rank - labels_rank;
143143
if (rank_diff == 1)
144-
weights = (int)array_ops.squeeze(weights_tensor, new int[] { -1 });
144+
weights = (float)array_ops.squeeze(weights_tensor, new int[] { -1 });
145145
return (labels, predictions, weights_tensor);
146146
}
147147

‎src/TensorFlowNET.Core/Operations/random_ops.py.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ public static Tensor random_uniform(Tensor shape,
8989
{
9090
name = scope;
9191
var minTensor = ops.convert_to_tensor(minval, dtype: dtype, name: "min");
92-
var maxTensor = ops.convert_to_tensor(maxval == null ? 1 : maxval, dtype: dtype, name: "max");
92+
var maxTensor = ops.convert_to_tensor(maxval == null ? 1 : (int)maxval, dtype: dtype, name: "max");
9393
var (seed1, seed2) = random_seed.get_seed(seed);
9494
if (dtype.is_integer())
9595
{

‎src/TensorFlowNET.Core/Tensors/Tensor.Implicit.cs

Lines changed: 13 additions & 67 deletions
Original file line numberDiff line numberDiff line change
@@ -1,79 +1,25 @@
1-
/*****************************************************************************
2-
Copyright 2018 The TensorFlow.NET Authors. All Rights Reserved.
3-
4-
Licensed under the Apache License, Version 2.0 (the "License");
5-
you may not use this file except in compliance with the License.
6-
You may obtain a copy of the License at
7-
8-
http://www.apache.org/licenses/LICENSE-2.0
9-
10-
Unless required by applicable law or agreed to in writing, software
11-
distributed under the License is distributed on an "AS IS" BASIS,
12-
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13-
See the License for the specific language governing permissions and
14-
limitations under the License.
15-
******************************************************************************/
16-
1+
using NumSharp;
172
using System;
3+
using System.Collections.Generic;
4+
using System.Text;
185

196
namespace Tensorflow
207
{
218
public partial class Tensor
229
{
23-
public static implicit operator Tensor(bool value)
10+
/// <summary>
11+
/// Issue unresolved, will cause name_scope problem.
12+
/// </summary>
13+
/// <param name="scalar"></param>
14+
/*public static implicit operator Tensor(double scalar)
2415
{
25-
return tf.constant(value, TF_DataType.TF_BOOL);
26-
}
27-
28-
public static implicit operator Tensor(sbyte value)
29-
{
30-
return tf.constant(value, TF_DataType.TF_INT8);
31-
}
32-
33-
public static implicit operator Tensor(byte value)
34-
{
35-
return tf.constant(value, TF_DataType.TF_INT16);
36-
}
37-
38-
public static implicit operator Tensor(ushort value)
39-
{
40-
return tf.constant(value, TF_DataType.TF_UINT16);
41-
}
42-
43-
public static implicit operator Tensor(short value)
44-
{
45-
return tf.constant(value, TF_DataType.TF_INT16);
46-
}
16+
return constant_op.constant(scalar);
17+
}*/
4718

48-
public static implicit operator Tensor(int value)
19+
/*public static implicit operator Tensor(int scalar)
4920
{
50-
return tf.constant(value, TF_DataType.TF_INT32);
51-
}
52-
53-
public static implicit operator Tensor(uint value)
54-
{
55-
return tf.constant(value, TF_DataType.TF_UINT32);
56-
}
57-
58-
public static implicit operator Tensor(long value)
59-
{
60-
return tf.constant(value, TF_DataType.TF_INT64);
61-
}
62-
63-
public static implicit operator Tensor(ulong value)
64-
{
65-
return tf.constant(value, TF_DataType.TF_UINT64);
66-
}
67-
68-
public static implicit operator Tensor(float value)
69-
{
70-
return tf.constant(value, TF_DataType.TF_FLOAT);
71-
}
72-
73-
public static implicit operator Tensor(double value)
74-
{
75-
return tf.constant(value, TF_DataType.TF_DOUBLE);
76-
}
21+
return constant_op.constant(scalar);
22+
}*/
7723

7824
public static implicit operator IntPtr(Tensor tensor)
7925
{

‎test/TensorFlowNET.UnitTest/ConstantTest.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ public void ScalarConst()
1919
var tensor3 = tf.constant(6.0); // double
2020
}
2121

22-
[DataTestMethod]
22+
/*[DataTestMethod]
2323
[DataRow(int.MinValue)]
2424
[DataRow(-1)]
2525
[DataRow(0)]
@@ -85,7 +85,7 @@ public void StringConst()
8585
var result = sess.run(tensor);
8686
Assert.IsTrue(result.Data<string>()[0] == str);
8787
});
88-
}
88+
}*/
8989

9090
[TestMethod]
9191
public void ZerosConst()

‎test/TensorFlowNET.UnitTest/GradientTest.cs

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,11 +91,14 @@ public void StridedSlice()
9191

9292
var g = tf.gradients(y, new Tensor[] { slice, slice });
9393

94-
var r = slice.eval();
94+
with(tf.Session(graph), sess =>
95+
{
96+
var r = sess.run(slice);
9597

96-
Assert.IsTrue(Enumerable.SequenceEqual(r.shape, new[] { 2, 1, 2 }));
97-
Assert.IsTrue(Enumerable.SequenceEqual(r[0].GetData<int>(), new[] { 11, 13 }));
98-
Assert.IsTrue(Enumerable.SequenceEqual(r[1].GetData<int>(), new[] { 51, 53 }));
98+
Assert.IsTrue(Enumerable.SequenceEqual(r.shape, new[] { 2, 1, 2 }));
99+
Assert.IsTrue(Enumerable.SequenceEqual(r[0].GetData<int>(), new[] { 11, 13 }));
100+
Assert.IsTrue(Enumerable.SequenceEqual(r[1].GetData<int>(), new[] { 51, 53 }));
101+
});
99102
}
100103
}
101104
}

‎test/TensorFlowNET.UnitTest/nest_test/NestTest.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public void TestInitialize()
5656
//# Check that flatten fails if attributes are not iterable
5757
// with self.assertRaisesRegexp(TypeError, "object is not iterable"):
5858
// flat = nest.flatten(NestTest.BadAttr())
59-
59+
[Ignore]
6060
[TestMethod]
6161
public void testFlattenAndPack()
6262
{
@@ -380,7 +380,7 @@ public void testIsSequence()
380380
// def testHeterogeneousComparison(self):
381381
// nest.assert_same_structure({"a": 4}, _CustomMapping(a= 3))
382382
// nest.assert_same_structure(_CustomMapping(b=3), {"b": 4})
383-
383+
[Ignore]
384384
[TestMethod]
385385
public void testMapStructure()
386386
{

0 commit comments

Comments
 (0)