Skip to content

Commit 152a321

Browse files
committed
Fix the case when SwiftUI create new View struct without call onAppears. Now we always do a query check when hitting empty Image
1 parent 0c17688 commit 152a321

File tree

3 files changed

+12
-8
lines changed

3 files changed

+12
-8
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ profile
1818
DerivedData
1919
*.hmap
2020
*.ipa
21+
IDEWorkspaceChecks.plist
2122

2223
# Bundler
2324
.bundle

Example/Podfile.lock

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ PODS:
88
- libwebp/mux (1.0.3):
99
- libwebp/demux
1010
- libwebp/webp (1.0.3)
11-
- SDWebImage (5.2.2):
12-
- SDWebImage/Core (= 5.2.2)
13-
- SDWebImage/Core (5.2.2)
14-
- SDWebImageSwiftUI (0.3.0):
11+
- SDWebImage (5.2.3):
12+
- SDWebImage/Core (= 5.2.3)
13+
- SDWebImage/Core (5.2.3)
14+
- SDWebImageSwiftUI (0.3.1):
1515
- SDWebImage (~> 5.1)
1616
- SDWebImageWebPCoder (0.2.5):
1717
- libwebp (~> 1.0)
@@ -22,7 +22,7 @@ DEPENDENCIES:
2222
- SDWebImageWebPCoder
2323

2424
SPEC REPOS:
25-
https://github.com/cocoapods/specs.git:
25+
trunk:
2626
- libwebp
2727
- SDWebImage
2828
- SDWebImageWebPCoder
@@ -33,10 +33,10 @@ EXTERNAL SOURCES:
3333

3434
SPEC CHECKSUMS:
3535
libwebp: 057912d6d0abfb6357d8bb05c0ea470301f5d61e
36-
SDWebImage: 5fcdb02cc35e05fc35791ec514b191d27189f872
37-
SDWebImageSwiftUI: 9fa220c3c9a69a383f2db5fabc97748ac4e4b696
36+
SDWebImage: 46a7f73228f84ce80990c786e4372cf4db5875ce
37+
SDWebImageSwiftUI: 1b67183dd2ef0321b2ccf578775de8e47eaceb77
3838
SDWebImageWebPCoder: 947093edd1349d820c40afbd9f42acb6cdecd987
3939

4040
PODFILE CHECKSUM: 3fb06a5173225e197f3a4bf2be7e5586a693257a
4141

42-
COCOAPODS: 1.7.5
42+
COCOAPODS: 1.8.3

SDWebImageSwiftUI/Classes/WebImage.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,9 @@ public struct WebImage : View {
4545
let emptyImage = Image(uiImage: UIImage())
4646
#endif
4747
image = emptyImage
48+
// load remote image here, SwiftUI sometimes will create a new View struct without calling `onAppear` (like enter EditMode) :)
49+
// this can ensure we load the image, SDWebImage take care of the duplicated query
50+
self.imageManager.load()
4851
}
4952
return configurations.reduce(image) { (previous, configuration) in
5053
configuration(previous)

0 commit comments

Comments
 (0)