From ee882995d4847d91d397f1b8b74bb9f0f659bcc7 Mon Sep 17 00:00:00 2001 From: Lukas Harbarth Date: Fri, 9 May 2025 09:41:43 +0200 Subject: [PATCH 1/3] docs(ObjectPage): adjust description of `onBeforeNavigate` --- packages/main/src/components/ObjectPage/types/index.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/main/src/components/ObjectPage/types/index.ts b/packages/main/src/components/ObjectPage/types/index.ts index 010c016e9a7..f0e8273d9a7 100644 --- a/packages/main/src/components/ObjectPage/types/index.ts +++ b/packages/main/src/components/ObjectPage/types/index.ts @@ -120,9 +120,9 @@ export interface ObjectPagePropTypes extends Omit { */ placeholder?: ReactNode; /** - * The event is fired before the selected section is changed using the navigation. It can be aborted by the application with `preventDefault()`, which means that there will be no navigation. + * Fired when a section is selected via the tab bar. To cancel navigation, call `event.preventDefault()` within the event handler. * - * __Note:__ This event is only fired when navigating via tab-bar. + * __Note:__ This event is triggered every time a user selects a section, even if the section is already selected. */ onBeforeNavigate?: (event: Ui5CustomEvent) => void; /** From 3dddc64960f62cb725a41cbe7943be65ae0e251a Mon Sep 17 00:00:00 2001 From: Lukas Harbarth Date: Fri, 9 May 2025 09:43:47 +0200 Subject: [PATCH 2/3] Update index.ts --- packages/main/src/components/ObjectPage/types/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/main/src/components/ObjectPage/types/index.ts b/packages/main/src/components/ObjectPage/types/index.ts index f0e8273d9a7..8af20cd3b04 100644 --- a/packages/main/src/components/ObjectPage/types/index.ts +++ b/packages/main/src/components/ObjectPage/types/index.ts @@ -120,7 +120,7 @@ export interface ObjectPagePropTypes extends Omit { */ placeholder?: ReactNode; /** - * Fired when a section is selected via the tab bar. To cancel navigation, call `event.preventDefault()` within the event handler. + * Fired when a section is selected via the tab bar, before navigation occurs. To cancel navigation, call `event.preventDefault()` within the event handler. * * __Note:__ This event is triggered every time a user selects a section, even if the section is already selected. */ From 4a410bf849dec891c4041ad6882d77d9eb678a5a Mon Sep 17 00:00:00 2001 From: Lukas Harbarth Date: Fri, 9 May 2025 09:49:28 +0200 Subject: [PATCH 3/3] Update index.ts --- packages/main/src/components/ObjectPage/types/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/main/src/components/ObjectPage/types/index.ts b/packages/main/src/components/ObjectPage/types/index.ts index 8af20cd3b04..6977d239605 100644 --- a/packages/main/src/components/ObjectPage/types/index.ts +++ b/packages/main/src/components/ObjectPage/types/index.ts @@ -122,7 +122,7 @@ export interface ObjectPagePropTypes extends Omit { /** * Fired when a section is selected via the tab bar, before navigation occurs. To cancel navigation, call `event.preventDefault()` within the event handler. * - * __Note:__ This event is triggered every time a user selects a section, even if the section is already selected. + * __Note:__ This event is fired every time a user selects a section, even if the section is already selected. */ onBeforeNavigate?: (event: Ui5CustomEvent) => void; /**