fix(cypress-commands): make the options optional for clickUi5ListItemByText #7316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 14933587679Details
💛 - Coveralls |
…tional {}
Set the default options to `{force: true}` to mimic the behavior as before
Jianrong-Yu
force-pushed
the
fix-cypress-commands-clickUi5ListItemByText
branch
from
6709f44 to
2f284f3
Compare
Lukas742
requested changes
May 9, 2025
There was a problem hiding this comment.
Hi @Jianrong-Yu
thanks a lot for your contribution, it's really appreciated!
Adding the options parameter in the type definitions was an oversight. Initially, I planned to remove it again since force: true doesn't work, but we can definitely keep it for the other options. The type just needs to reflect that (please see my comment below).
…clickUi5ListItemByText
Lukas742
approved these changes
May 12, 2025
|
🎉 This PR is included in version v2.11.0-rc.0 🎉 The release is available on v2.11.0-rc.0 Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version v2.10.1 🎉 The release is available on v2.10.1 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last commit for
cypress-commands/src/commands.ts, newoptionsparameter is added as a mandatory parameter for functionclickUi5ListItemByTextbut it's not used.It should be optional as other functions and the default value should be
{}.Pull Request Checklist