Fix Vec::to_pyo3_ast

youknowone · youknowone · commit c4841946b586 · 2023-05-22T15:06:00.000+09:00
diff --git a/ast/src/pyo3.rs b/ast/src/pyo3.rs
@@ -38,11 +38,8 @@ impl<T: ToPyo3Ast> ToPyo3Ast for Option<T> {
 
 impl<T: ToPyo3Ast> ToPyo3Ast for Vec<T> {
     fn to_pyo3_ast(&self, py: Python) -> PyResult<Py<PyAny>> {
-        let list = PyList::empty(py);
-        for item in self {
-            let py_item = item.to_pyo3_ast(py)?;
-            list.append(py_item)?;
-        }
+        let elts = self.iter().map(|item| item.to_pyo3_ast(py)).collect::<Result<Vec<_>, _>>()?;
+        let list = PyList::new(py, elts);
         Ok(list.into())
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -38,11 +38,8 @@ impl<T: ToPyo3Ast> ToPyo3Ast for Option<T> {`
`38`	`38`
`39`	`39`	`impl<T: ToPyo3Ast> ToPyo3Ast for Vec<T> {`
`40`	`40`	`fn to_pyo3_ast(&self, py: Python) -> PyResult<Py<PyAny>> {`
`41`		`- let list = PyList::empty(py);`
`42`		`- for item in self {`
`43`		`- let py_item = item.to_pyo3_ast(py)?;`
`44`		`- list.append(py_item)?;`
`45`		`- }`
	`41`	`+ let elts = self.iter().map(\|item\| item.to_pyo3_ast(py)).collect::<Result<Vec<_>, _>>()?;`
	`42`	`+ let list = PyList::new(py, elts);`
`46`	`43`	`Ok(list.into())`
`47`	`44`	`}`
`48`	`45`	`}`