From 6cde98f2e93080339d0f6bdbe1b991e7a8daf9dd Mon Sep 17 00:00:00 2001 From: Gnanesh R Date: Thu, 30 May 2019 17:04:50 +0530 Subject: [PATCH 1/2] Assign a val to local variable `scalar` before returning Compare bytes of two values --- redisgraph/query_result.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/redisgraph/query_result.py b/redisgraph/query_result.py index 474726b..5bf06cf 100644 --- a/redisgraph/query_result.py +++ b/redisgraph/query_result.py @@ -116,6 +116,7 @@ def parse_edge(self, cell): def parse_scalar(self, cell): scalar_type = int(cell[0]) value = cell[1] + scalar = None if scalar_type == ResultSetScalarTypes.PROPERTY_NULL: scalar = None @@ -127,9 +128,9 @@ def parse_scalar(self, cell): scalar = int(value) elif scalar_type == ResultSetScalarTypes.PROPERTY_BOOLEAN: - if value == "true": + if value == b"true": scalar = True - elif value == "false": + elif value == b"false": scalar = False else: print("Unknown boolean type\n") From 7565ca406c2d8bda422fdb7f3dcb255692d19916 Mon Sep 17 00:00:00 2001 From: Gnanesh R Date: Fri, 31 May 2019 00:50:41 +0530 Subject: [PATCH 2/2] decode `value` before checking --- redisgraph/query_result.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/redisgraph/query_result.py b/redisgraph/query_result.py index 5bf06cf..1c6a79d 100644 --- a/redisgraph/query_result.py +++ b/redisgraph/query_result.py @@ -128,9 +128,10 @@ def parse_scalar(self, cell): scalar = int(value) elif scalar_type == ResultSetScalarTypes.PROPERTY_BOOLEAN: - if value == b"true": + value = value.decode() if isinstance(value, bytes) else value + if value == "true": scalar = True - elif value == b"false": + elif value == "false": scalar = False else: print("Unknown boolean type\n")