Skip to content

Commit d312d48

Browse files
committed
pass test on both python versions
1 parent 260926c commit d312d48

File tree

4 files changed

+17
-28
lines changed

4 files changed

+17
-28
lines changed

redisgraph/edge.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ def __init__(self, src_node, relation, dest_node, edge_id=None, properties=None)
2121
def toString(self):
2222
res = ""
2323
if self.properties:
24-
props = ','.join(key+':'+str(quote_string(val)) for key, val in self.properties.items())
24+
props = ','.join(key+':'+str(quote_string(val)) for key, val in sorted(self.properties.items()))
2525
res += '{' + props + '}'
2626

2727
return res
@@ -38,7 +38,7 @@ def __str__(self):
3838
if self.relation:
3939
res += ":" + self.relation
4040
if self.properties:
41-
props = ','.join(key+':'+str(quote_string(val)) for key, val in self.properties.items())
41+
props = ','.join(key+':'+str(quote_string(val)) for key, val in sorted(self.properties.items()))
4242
res += '{' + props + '}'
4343
res += ']->'
4444

redisgraph/node.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ def __init__(self, node_id=None, alias=None, label=None, properties={}):
1616
def toString(self):
1717
res = ""
1818
if self.properties:
19-
props = ','.join(key+':'+str(quote_string(val)) for key, val in self.properties.items())
19+
props = ','.join(key+':'+str(quote_string(val)) for key, val in sorted(self.properties.items()))
2020
res += '{' + props + '}'
2121

2222
return res
@@ -28,7 +28,7 @@ def __str__(self):
2828
if self.label:
2929
res += ':' + self.label
3030
if self.properties:
31-
props = ','.join(key+':'+str(quote_string(val)) for key, val in self.properties.items())
31+
props = ','.join(key+':'+str(quote_string(val)) for key, val in sorted(self.properties.items()))
3232
res += '{' + props + '}'
3333
res += ')'
3434

setup.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@ def read_all(f):
1919
packages=find_packages(),
2020
install_requires=requirements,
2121
classifiers=[
22-
'Development Status :: 4 - Beta',
22+
'Topic :: Database',
23+
'Programming Language :: Python',
2324
'Intended Audience :: Developers',
2425
'License :: OSI Approved :: BSD License',
25-
'Programming Language :: Python :: 2.7',
26-
'Topic :: Database'
26+
'Development Status :: 5 - Production/Stable'
2727
],
28-
keywords='Redis Graph Extension',
2928
author='RedisLabs',
29+
keywords='Redis Graph',
3030
author_email='oss@redislabs.com'
3131
)

test.py

Lines changed: 9 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ def test_graph_creation(self):
3737
result = redis_graph.query(query)
3838
self.assertEqual([1, 2.3, "4", True, False, None], result.result_set[0][0])
3939

40-
# All done, remove graph.
40+
# All done, remove graph.
4141
redis_graph.delete()
4242

4343
def test_array_functions(self):
@@ -46,48 +46,37 @@ def test_array_functions(self):
4646
query = """CREATE (p:person{name:'a',age:32, array:[0,1,2]})"""
4747
redis_graph.query(query)
4848

49-
query = """CREATE (p:person{name:'b',age:30, array:[3,4,5]})"""
50-
redis_graph.query(query)
51-
5249
query = """WITH [0,1,2] as x return x"""
5350
result = redis_graph.query(query)
5451
self.assertEqual([0, 1, 2], result.result_set[0][0])
5552

56-
query = """MATCH(n) return collect(n) as x"""
53+
query = """MATCH(n) return collect(n)"""
5754
result = redis_graph.query(query)
5855

59-
a = Node(label='person', properties={'name': 'a', 'age': 32, 'array': [0, 1, 2]})
60-
b = Node(label='person', properties={'name': 'b', 'age': 30, 'array': [3, 4, 5]})
61-
62-
self.assertEqual([a, b], result.result_set[0][0])
56+
a = Node(node_id=0, label='person', properties={'name': 'a', 'age': 32, 'array': [0, 1, 2]})
6357

58+
self.assertEqual([a], result.result_set[0][0])
6459

6560
# All done, remove graph.
6661
redis_graph.delete()
6762

68-
6963
def test_path(self):
7064
redis_graph = Graph('social', self.r)
7165

7266
node0 = Node(node_id=0, label="L1")
7367
node1 = Node(node_id=1, label="L1")
74-
node2 = Node(node_id=2, label="L1")
7568
edge01 = Edge(node0, "R1", node1, edge_id=0, properties={'value': 1})
76-
edge12 = Edge(node1, "R1", node2, edge_id=1, properties={'value': 2})
7769

7870
redis_graph.add_node(node0)
7971
redis_graph.add_node(node1)
80-
redis_graph.add_node(node2)
8172
redis_graph.add_edge(edge01)
82-
redis_graph.add_edge(edge12)
8373

8474
redis_graph.flush()
8575

8676
path01 = Path.new_empty_path().add_node(node0).add_edge(edge01).add_node(node1)
87-
path12 = Path.new_empty_path().add_node(node1).add_edge(edge12).add_node(node2)
88-
expected_results = [[path01], [path12]]
77+
expected_results = [[path01]]
8978

90-
query = "MATCH p=(:L1)-[:R1]->(:L1) RETURN p"
79+
query = "MATCH p=(:L1)-[:R1]->(:L1) RETURN p ORDER BY p"
9180
result = redis_graph.query(query)
9281
self.assertEqual(expected_results, result.result_set)
9382

@@ -139,9 +128,9 @@ def test_stringify_query_result(self):
139128
redis_graph.add_edge(edge)
140129

141130
self.assertEqual(str(john),
142-
"""(a:person{name:"John Doe",age:33,gender:"male",status:"single"})""")
131+
"""(a:person{age:33,gender:"male",name:"John Doe",status:"single"})""")
143132
self.assertEqual(str(edge),
144-
"""(a:person{name:"John Doe",age:33,gender:"male",status:"single"})""" +
133+
"""(a:person{age:33,gender:"male",name:"John Doe",status:"single"})""" +
145134
"""-[:visited{purpose:"pleasure"}]->""" +
146135
"""(b:country{name:"Japan"})""")
147136
self.assertEqual(str(japan), """(b:country{name:"Japan"})""")
@@ -156,7 +145,7 @@ def test_stringify_query_result(self):
156145
visit = result.result_set[0][1]
157146
country = result.result_set[0][2]
158147

159-
self.assertEqual(str(person), """(:person{name:"John Doe",age:33,gender:"male",status:"single"})""")
148+
self.assertEqual(str(person), """(:person{age:33,gender:"male",name:"John Doe",status:"single"})""")
160149
self.assertEqual(str(visit), """()-[:visited{purpose:"pleasure"}]->()""")
161150
self.assertEqual(str(country), """(:country{name:"Japan"})""")
162151

0 commit comments

Comments
 (0)