Skip to content

Commit 0009925

Browse files
Fixed implicit conversions to make compile work
1 parent 096cb0b commit 0009925

File tree

5 files changed

+15
-7
lines changed

5 files changed

+15
-7
lines changed

language-adaptors/rxjava-scala/src/main/scala/rx/lang/scala/ImplicitFunctionConversions.scala

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,17 @@ import scala.language.implicitConversions
3333
object ImplicitFunctionConversions {
3434
import language.implicitConversions
3535

36-
implicit def schedulerActionToFunc2[T](action: (Scheduler, T) => Subscription): Func2[rx.Scheduler, T, rx.Subscription] with Object {def call(s: rx.Scheduler, t: T): rx.Subscription} =
36+
// implicit def schedulerActionToFunc2[T](action: (Scheduler, T) => Subscription): Func2[rx.Scheduler, T, rx.Subscription] with Object {def call(s: rx.Scheduler, t: T): rx.Subscription} =
37+
// new Func2[rx.Scheduler, T, rx.Subscription] {
38+
// def call(s: rx.Scheduler, t: T): rx.Subscription = {
39+
// action(rx.lang.scala.Scheduler(s), t).asJavaSubscription
40+
// }
41+
// }
42+
43+
implicit def schedulerActionToFunc2[T](action: (Scheduler, T) => Subscription) =
3744
new Func2[rx.Scheduler, T, rx.Subscription] {
3845
def call(s: rx.Scheduler, t: T): rx.Subscription = {
39-
action(rx.lang.scala.Scheduler(s), t).asJavaSubscription
46+
action(Scheduler(s), t).asJavaSubscription
4047
}
4148
}
4249

language-adaptors/rxjava-scala/src/main/scala/rx/lang/scala/Scheduler.scala

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ import rx.util.functions.{Action0, Action1, Func2}
2323
* Represents an object that schedules units of work.
2424
*/
2525
trait Scheduler {
26+
import rx.lang.scala.ImplicitFunctionConversions._
27+
2628
val asJavaScheduler: rx.Scheduler
2729

2830
/**
@@ -73,7 +75,8 @@ trait Scheduler {
7375
* @return a subscription to be able to unsubscribe from action.
7476
*/
7577
private def schedule[T](state: T, action: (Scheduler, T) => Subscription, delayTime: Duration): Subscription = {
76-
Subscription(asJavaScheduler.schedule(state, action, delayTime.length, delayTime.unit))
78+
val xxx = schedulerActionToFunc2(action)
79+
Subscription(asJavaScheduler.schedule(state, xxx, delayTime.length, delayTime.unit))
7780
}
7881

7982
/**

language-adaptors/rxjava-scala/src/main/scala/rx/lang/scala/Subscription.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ object Subscription {
5252
case x: rx.subscriptions.CompositeSubscription => new CompositeSubscription(x)
5353
case x: rx.subscriptions.MultipleAssignmentSubscription => new MultipleAssignmentSubscription(x)
5454
case x: rx.subscriptions.SerialSubscription => new SerialSubscription(x)
55-
case x: rx.Subscription => Subscription { x.unsubscribe() }
55+
case x: rx.Subscription => apply { x.unsubscribe() }
5656
}
5757
}
5858

language-adaptors/rxjava-scala/src/main/scala/rx/lang/scala/subjects/BehaviorSubject.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import rx.lang.scala.Subject
1919

2020
object BehaviorSubject {
2121
def apply[T](value: T): BehaviorSubject[T] = {
22-
new BehaviorSubject[T](rx.subjects.BehaviorSubject.createWithDefaultValue(value))
22+
new BehaviorSubject[T](rx.subjects.BehaviorSubject.create(value))
2323
}
2424
}
2525

language-adaptors/rxjava-scala/src/test/scala/rx/lang/scala/subscriptions/SubscriptionTests.scala

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ import org.junit.Assert._
44
import org.junit.Test
55
import org.scalatest.junit.JUnitSuite
66

7-
import rx.lang.scala.Subscription
8-
97
class SubscriptionTests extends JUnitSuite {
108

119
@Test

0 commit comments

Comments
 (0)