Skip to content

Commit 131cd64

Browse files
Rollup merge of #124480 - Enselic:on-broken-pipe, r=jieyouxu
Change `SIGPIPE` ui from `#[unix_sigpipe = "..."]` to `-Zon-broken-pipe=...` In the stabilization [attempt](rust-lang/rust#120832) of `#[unix_sigpipe = "sig_dfl"]`, a concern was [raised ](rust-lang/rust#120832 (comment)) related to using a language attribute for the feature: Long term, we want `fn lang_start()` to be definable by any crate, not just libstd. Having a special language attribute in that case becomes awkward. So as a first step towards the next stabilization attempt, this PR changes the `#[unix_sigpipe = "..."]` attribute to a compiler flag `-Zon-broken-pipe=...` to remove that concern, since now the language is not "contaminated" by this feature. Another point was [also raised](rust-lang/rust#120832 (comment)), namely that the ui should not leak **how** it does things, but rather what the **end effect** is. The new flag uses the proposed naming. This is of course something that can be iterated on further before stabilization. Tracking issue: rust-lang/rust#97889
2 parents b1e5460 + 2d0cc5c commit 131cd64

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/eval.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@ pub fn create_ecx<'mir, 'tcx: 'mir>(
387387
let main_ptr = ecx.fn_ptr(FnVal::Instance(entry_instance));
388388

389389
// Always using DEFAULT is okay since we don't support signals in Miri anyway.
390-
// (This means we are effectively ignoring `#[unix_sigpipe]`.)
390+
// (This means we are effectively ignoring `-Zon-broken-pipe`.)
391391
let sigpipe = rustc_session::config::sigpipe::DEFAULT;
392392

393393
ecx.call_function(

0 commit comments

Comments
 (0)