Skip to content
This repository was archived by the owner on Jul 12, 2020. It is now read-only.

Commit 08986c1

Browse files
david0beberlei
authored andcommitted
Fix: make PatchBuilder->changeToken() case sensitive
1 parent 1086616 commit 08986c1

File tree

2 files changed

+17
-1
lines changed

2 files changed

+17
-1
lines changed

src/main/QafooLabs/Refactoring/Adapters/PatchBuilder/PatchBuilder.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public function changeToken($originalLine, $oldToken, $newToken)
7373
$newLine = $this->buffer->getLine($this->createLineNumber($originalLine));
7474

7575
$newLine = preg_replace(
76-
'!(^|[^a-z0-9])(' . preg_quote($oldToken) . ')([^a-z0-9]|$)!i',
76+
'!(^|[^a-z0-9])(' . preg_quote($oldToken) . ')([^a-z0-9]|$)!',
7777
'\1' . $newToken . '\3',
7878
$newLine
7979
);

src/test/QafooLabs/Refactoring/Adapters/PatchBuilder/PatchBuilderTest.php

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,22 @@ public function testChangeTokenOnLineAlone()
4141
line6
4242
line7
4343
44+
DIFF;
45+
46+
$this->assertEquals($expected, $this->builder->generateUnifiedDiff());
47+
}
48+
49+
public function testChangeIsCaseSensitive() {
50+
$this->builder = new PatchBuilder('$bar = new Bar();');
51+
$this->builder->changeToken(1, 'Bar', 'Foo');
52+
53+
$expected = <<<DIFF
54+
--- a/
55+
+++ b/
56+
@@ -1,1 +1,1 @@
57+
-\$bar = new Bar();
58+
+\$bar = new Foo();
59+
4460
DIFF;
4561
$this->assertEquals($expected, $this->builder->generateUnifiedDiff());
4662
}

0 commit comments

Comments
 (0)