Added a configuration of registration open, and a test

Author: orronai

lms/lmsweb/config.py.example

@@ -10,6 +10,8 @@ MAILGUN_DOMAIN = os.getenv('MAILGUN_DOMAIN', 'mail.pythonic.guru')
 SERVER_ADDRESS = os.getenv('SERVER_ADDRESS', '127.0.0.1:5000')
 SITE_NAME = 'Learning Python'
 
+# REGISTRATION CONFIGURATIONS
+REGISTRATION_OPEN = True
 CONFIRMATION_TIME = 3600
 
 # MAIL CONFIGURATION

lms/lmsweb/translations/en/LC_MESSAGES/messages.po

@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version:  lmsweb-1.0\n"
 "Report-Msgid-Bugs-To: bugs@mesicka.com\n"
-"POT-Creation-Date: 2021-09-12 11:15+0300\n"
+"POT-Creation-Date: 2021-09-12 15:10+0300\n"
 "PO-Revision-Date: 2020-09-16 18:29+0300\n"
 "Last-Translator: Or Ronai\n"
 "Language: en\n"
@@ -45,15 +45,19 @@ msgstr "The automatic checker couldn't run your code."
 msgid "אחי, בדקת את הקוד שלך?"
 msgstr "Bro, did you check your code?"
 
-#: lmsweb/views.py:134
+#: lmsweb/views.py:122
+msgid "לא ניתן להירשם כעת"
+msgstr "Can not register now"
+
+#: lmsweb/views.py:139
 msgid "ההרשמה בוצעה בהצלחה"
 msgstr "Registration successfully"
 
-#: lmsweb/views.py:156
+#: lmsweb/views.py:161
 msgid "קישור האימות פג תוקף, קישור חדש נשלח אל תיבת המייל שלך"
 msgstr "The confirmation link is expired, new link has been sent to your email"
 
-#: lmsweb/views.py:169
+#: lmsweb/views.py:174
 #, fuzzy
 msgid "המשתמש שלך אומת בהצלחה, כעת אתה יכול להתחבר למערכת"
 msgstr "Your user has been successfully confirmed, you can now login"
@@ -177,7 +181,7 @@ msgstr "Password"
 msgid "התחבר"
 msgstr "Login"
 
-#: templates/login.html:38 templates/signup.html:22
+#: templates/login.html:39 templates/signup.html:22
 msgid "הירשם"
 msgstr "Register"
 

lms/lmsweb/views.py

@@ -117,6 +117,11 @@ def login(login_message: Optional[str] = None):
 
 @webapp.route('/signup', methods=['GET', 'POST'])
 def signup():
+    if not webapp.config.get('REGISTRATION_OPEN', False):
+        return redirect(url_for(
+            'login', login_message=_('לא ניתן להירשם כעת'),
+        ))
+
     form = RegisterForm()
     if not form.validate_on_submit():
         return render_template('signup.html', form=form)

lms/templates/login.html

@@ -34,8 +34,10 @@ <h1 id="main-title" class="h3 font-weight-normal">{{ _('התחברות') }}</h1>
           <input class="form-control form-control-lg" type="hidden" name="next" id="next" value="{{ request.args.get('next', '') }}">
           <button class="btn btn-primary btn-lg btn-block">{{ _('התחבר') }}</button>
         </form>
+        {% if config.REGISTRATION_OPEN %}
         <hr class="mt-3 mb-3"/>
         <a href="/signup" class="btn btn-success btn-sm" role="button">{{ _('הירשם') }}</a>
+        {% endif %}
       </div>
     </div>
   </div>

tests/conftest.py

@@ -75,6 +75,11 @@ def disable_mail_sending():
     webapp.config['TESTING'] = True
 
 
+@pytest.fixture(autouse=True, scope='session')
+def enable_registration():
+    webapp.config['REGISTRATION_OPEN'] = True
+
+
 def disable_shareable_solutions():
     webapp.config['SHAREABLE_SOLUTIONS'] = False
 
@@ -87,6 +92,10 @@ def enable_users_comments():
     webapp.config['USERS_COMMENTS'] = True
 
 
+def disable_registration():
+    webapp.config['REGISTRATION_OPEN'] = False
+
+
 def use_limiter(func):
     @wraps(func)
     def wrapper(*args, **kwargs):

tests/test_registration.py

@@ -6,6 +6,7 @@
 from lms.lmsweb.config import CONFIRMATION_TIME
 from lms.lmsdb.models import User
 from lms.models.register import generate_confirmation_token
+from tests import conftest
 
 
 class TestRegistration:
@@ -157,3 +158,21 @@ def test_expired_token(client: FlaskClient):
             }, follow_redirects=True)
             success_login_response = client.get('/exercises')
             assert success_login_response.status_code == 200
+
+    @staticmethod
+    def test_registartion_closed(client: FlaskClient, captured_templates):
+        conftest.disable_registration()
+        client.post('/signup', data={
+            'email': 'some_user123@mail.com',
+            'username': 'some_user',
+            'fullname': 'some_name',
+            'password': 'some_password',
+            'confirm': 'some_password',
+        }, follow_redirects=True)
+        user = User.get_or_none(User.username == 'some_user')
+        assert user is None
+
+        response = client.get('/signup')
+        template, _ = captured_templates[-1]
+        assert template.name == 'login.html'
+        assert '/signup' not in response.get_data(as_text=True)