Added skipif for sending mail test and split a test function

Author: orronai

tests/test_registration.py

@@ -4,6 +4,7 @@
 from flask.testing import FlaskClient
 import pytest
 
+from lms.lmsweb import config_file
 from lms.lmsweb.config import CONFIRMATION_TIME, MAIL_DEFAULT_SENDER
 from lms.lmsdb.models import User
 from lms.models.users import generate_user_token
@@ -133,6 +134,10 @@ def test_expired_token(client: FlaskClient):
             assert success_login_response.status_code == 200
 
     @staticmethod
+    @pytest.mark.skipif(
+        condition=not config_file.is_file(),
+        reason='should run with configuration file and correct mail info',
+    )
     def test_successful_registration(client: FlaskClient, captured_templates):
         conftest.enable_mail_sending()
         client.post('/signup', data={

tests/test_users.py

@@ -112,14 +112,18 @@ def test_valid_change_password(captured_templates):
         assert check_logout_response.status_code == 302
 
     @staticmethod
-    def test_forgot_my_password(client: FlaskClient, captured_templates):
-        user = conftest.create_student_user(index=1)
+    def test_forgot_my_password_invalid_mail(
+        client: FlaskClient, captured_templates,
+    ):
         client.post('/reset-password', data={
             'email': 'fake-mail@mail.com',
         }, follow_redirects=True)
         template, _ = captured_templates[-1]
         assert template.name == "resetpassword.html"
 
+    @staticmethod
+    def test_forgot_my_password(client: FlaskClient, captured_templates):
+        user = conftest.create_student_user(index=1)
         client.post('/reset-password', data={
             'email': user.mail_address,
         }, follow_redirects=True)