Skip to content

Commit 20c5c60

Browse files
committed
Fixed flake8 error
1 parent b22c6dc commit 20c5c60

File tree

2 files changed

+33
-14
lines changed

2 files changed

+33
-14
lines changed

app/internal/translation.py

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,10 @@
1111
download_corpora.download_all()
1212

1313

14-
def translate_text(text: str, target_lang: str, original_lang: Optional[str] = None) -> str:
14+
def translate_text(text: str,
15+
target_lang: str,
16+
original_lang: Optional[str] = None
17+
) -> str:
1518
"""
1619
Translate text to the target language
1720
optionally given the original language
@@ -27,7 +30,9 @@ def translate_text(text: str, target_lang: str, original_lang: Optional[str] = N
2730
return text
2831

2932
try:
30-
return str(TextBlob(text).translate(from_lang=original_lang, to=_lang_full_to_short(target_lang)))
33+
return str(TextBlob(text).translate(
34+
from_lang=original_lang,
35+
to=_lang_full_to_short(target_lang)))
3136
except NotTranslated:
3237
return text
3338

@@ -55,7 +60,9 @@ def _get_user_language(user_id: int, session: SessionLocal) -> str:
5560
return language_user
5661

5762

58-
def translate_text_for_user(text: str, session: SessionLocal, user_id: int) -> str:
63+
def translate_text_for_user(text: str,
64+
session: SessionLocal,
65+
user_id: int) -> str:
5966
"""
6067
Gets a text and a user-id and returns the text,
6168
translated to the language the user speaks

tests/test_translation.py

Lines changed: 23 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,13 @@
22
from iso639 import languages
33
from textblob import TextBlob
44

5-
from app.internal.translation import \
6-
translate_text, \
7-
translate_text_for_user, \
8-
_get_user_language, \
9-
_lang_full_to_short, \
5+
from app.internal.translation import (
6+
translate_text,
7+
translate_text_for_user,
8+
_get_user_language,
9+
_lang_full_to_short,
1010
_detect_text_language
11+
)
1112

1213

1314
@pytest.mark.parametrize("text, target_lang, original_lang",
@@ -19,8 +20,10 @@
1920
def test_translate_text_with_original_lang(text, target_lang, original_lang):
2021
answer = translate_text(text, target_lang, original_lang)
2122
assert "Hello my friend" == answer
22-
assert TextBlob(text).detect_language() == languages.get(name=original_lang.capitalize()).alpha2
23-
assert TextBlob(answer).detect_language() == languages.get(name=target_lang.capitalize()).alpha2
23+
assert TextBlob(text).detect_language() == languages.get(
24+
name=original_lang.capitalize()).alpha2
25+
assert TextBlob(answer).detect_language() == languages.get(
26+
name=target_lang.capitalize()).alpha2
2427

2528

2629
@pytest.mark.parametrize("text, target_lang",
@@ -31,7 +34,8 @@ def test_translate_text_with_original_lang(text, target_lang, original_lang):
3134
def test_translate_text_without_original_lang(text, target_lang):
3235
answer = translate_text(text, target_lang)
3336
assert "Hello my friend" == answer
34-
assert TextBlob(answer).detect_language() == languages.get(name=target_lang.capitalize()).alpha2
37+
assert TextBlob(answer).detect_language() == languages.get(
38+
name=target_lang.capitalize()).alpha2
3539

3640

3741
@pytest.mark.parametrize("text, target_lang, original_lang",
@@ -41,7 +45,10 @@ def test_translate_text_without_original_lang(text, target_lang):
4145
("Hallo, mein Freund", "german", "german"),
4246
("Ciao amico", "italian", "italian")
4347
])
44-
def test_translate_text_with_same_original_target_lang_with_original_lang(text, target_lang, original_lang):
48+
def test_translate_text_with_same_original_target_lang_with_original_lang(
49+
text,
50+
target_lang,
51+
original_lang):
4552
answer = translate_text(text, target_lang, original_lang)
4653
assert answer == text
4754

@@ -53,7 +60,9 @@ def test_translate_text_with_same_original_target_lang_with_original_lang(text,
5360
("Hallo, mein Freund", "german"),
5461
("Ciao amico", "italian")
5562
])
56-
def test_translate_text_with_same_original_target_lang_without_original_lang(text, target_lang):
63+
def test_translate_text_with_same_original_target_lang_without_original_lang(
64+
text,
65+
target_lang):
5766
answer = translate_text(text, target_lang)
5867
assert answer == text
5968

@@ -100,7 +109,10 @@ def test_detect_text_language():
100109
("Bdonfdjourr", "english", "french"),
101110
("Hafdllnnc", "english", "german"),
102111
])
103-
def test_translate_text_with_text_impossible_to_translate(text, target_lang, original_lang):
112+
def test_translate_text_with_text_impossible_to_translate(
113+
text,
114+
target_lang,
115+
original_lang):
104116
answer = translate_text(text, target_lang, original_lang)
105117
assert answer == text
106118

0 commit comments

Comments
 (0)