fix: many code improvements

Author: elor555

app/internal/locations.py

@@ -32,12 +32,13 @@ def return_zip_to_location(session: Session) -> Optional[str]:
     Returns:
         A zip number for the user location.
     """
-    response = requests.get("http://ipinfo.io/json").json()
+    response = requests.get("http://ipinfo.io/json")
     if not response.ok:
         return None
+    location_by_ip = response.json()
     for location in session.query(Location).all():
-        if (location.city == response["city"]
-                and location.country == response["country"]):
+        if (location.city == location_by_ip["city"]
+                and location.country == location_by_ip["country"]):
             return location.zip_number
 
 

app/routers/dayview.py

@@ -212,11 +212,15 @@ async def dayview(
     current_time_with_attrs = CurrentTimeAttributes(date=day)
     inter_day = international_days.get_international_day_per_day(session, day)
     location_and_shabbat = locations.get_user_location(session)
-    location = location_and_shabbat["location"]["title"]
-    shabbat_obj = shabbat.get_shabbat_if_date_friday(
-        location_and_shabbat,
-        day.date(),
-    )
+    if location_and_shabbat:
+        location = location_and_shabbat["location"]["title"]
+        shabbat_obj = shabbat.get_shabbat_if_date_friday(
+            location_and_shabbat,
+            day.date(),
+        )
+    else:
+        location = None
+        shabbat_obj = None
     month = day.strftime("%B").upper()
     return templates.TemplateResponse(
         "calendar_day_view.html",