adding tests and fixing functions

Author: Sameera

src/future/builtins/new_min_max.py

@@ -19,14 +19,19 @@ def new_min_max(_builtin_func, *args, **kwargs):
     """
 
     for key, _ in kwargs.items():
-        if key not in set(['key', 'default']):
+        if key not in {'key', 'default'}:
             raise TypeError('Illegal argument %s', key)
 
+    if len(args) == 0:
+        raise TypeError
+
     if len(args) != 1 and kwargs.get('default') is not None:
         raise TypeError
 
     if len(args) == 1:
-        if len(args[0]) == 0:
+        try:
+            next(iter(args[0]))
+        except StopIteration:
             if kwargs.get('default') is not None:
                 return kwargs.get('default')
             else:

tests/test_future/test_builtins.py

@@ -6,7 +6,7 @@
 from __future__ import absolute_import, division, print_function, unicode_literals
 from future.builtins import (bytes, dict, int, range, round, str, super,
                              ascii, chr, hex, input, next, oct, open, pow,
-                             filter, map, zip)
+                             filter, map, zip, min, max)
 
 from future.utils import PY3, exec_, native_str, implements_iterator
 from future.tests.base import (unittest, skip26, expectedFailurePY2,
@@ -138,6 +138,7 @@ def test_round(self):
         self.assertEqual(round(0.125000001, 2), 0.13)
         self.assertEqual(round(123.5, 0), 124.0)
         self.assertEqual(round(123.5), 124)
+        self.assertEqual(round(123.5), 124)
         self.assertEqual(round(12.35, 2), 12.35)
         self.assertEqual(round(12.35, 1), 12.3)
         self.assertEqual(round(12.35, 0), 12.0)
@@ -1099,6 +1100,13 @@ def test_max(self):
         self.assertEqual(max(data, key=f),
                          sorted(reversed(data), key=f)[-1])
 
+        self.assertEqual(max([], default=5), 5)
+        with self.assertRaises(TypeError):
+            max(None, default=5)
+        with self.assertRaises(TypeError):
+            max(1, 2, default=0)
+        self.assertEqual(max([], default=0), 0)
+
     def test_min(self):
         self.assertEqual(min('123123'), '1')
         self.assertEqual(min(1, 2, 3), 1)
@@ -1140,6 +1148,12 @@ def __getitem__(self, index):
         f = keys.__getitem__
         self.assertEqual(min(data, key=f),
                          sorted(data, key=f)[0])
+        self.assertEqual(min([], default=5), 5)
+        self.assertEqual(min([], default=0), 0)
+        with self.assertRaises(TypeError):
+            max(None, default=5)
+        with self.assertRaises(TypeError):
+            max(1, 2, default=0)
 
     def test_next(self):
         it = iter(range(2))