Skip to content

Commit 142842c

Browse files
committed
Allow checklinks check to fail.
There are too many random arbitrary failures with this check. We still want the check to run to ensure we don't introduce any new errors. However, the random errors on external URLs are frustrating, especcially when a different URL fails on each run. And then when the URL is checked manually, it is clearly good. If the tool provided a flag to limit the check to intenral URLs only (it doesn't), we wouldn't use that anyway because we do want to know when an extenral URL becomes invalid. Although, I suppose we could do two runs, one intenral and one external and only allow the external to fail. But that will have to wait until such a feature is added to the tool or we find a better tool.
1 parent b7d6429 commit 142842c

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

.github/workflows/tox.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,9 @@ jobs:
6868
env:
6969
TOXENV: ${{ matrix.tox-env }}
7070

71+
# Allow checklinks to fail
72+
continue-on-error: ${{ matrix.tox-env == 'checklinks' }}
73+
7174
steps:
7275
- uses: actions/checkout@v2
7376
- name: Setup Python

0 commit comments

Comments
 (0)