Skip to content

Commit 7a7a835

Browse files
committed
Update packages
Signed-off-by: Victor Chang <vicchang@nvidia.com>
1 parent 5f3099a commit 7a7a835

File tree

8 files changed

+13
-15
lines changed

8 files changed

+13
-15
lines changed

src/Authentication/Configurations/OpenIdOptions.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,5 +31,8 @@ public class OpenIdOptions
3131

3232
[ConfigurationKeyName("Claims")]
3333
public Claims? Claims { get; set; }
34+
35+
[ConfigurationKeyName("Audiences")]
36+
public IList<string>? Audiences { get; set; }
3437
}
3538
}

src/Authentication/Extensions/AuthKeys.cs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,15 +24,7 @@ public static class AuthKeys
2424
public const string UserPolicyName = "User";
2525

2626
// Configuration Keys
27-
public const string ServerRealm = "ServerRealm";
28-
29-
public const string ServerRealmKey = "ServerRealmKey";
30-
public const string Claims = "Claims";
3127
public const string OpenId = "OpenId";
32-
public const string MonaiDeployAuthentication = "MonaiDeployAuthentication";
33-
public const string RequiredUserClaims = "RequiredUserClaims";
34-
public const string RequiredAdminClaims = "RequiredAdminClaims";
3528
public const string UserRoles = "user_roles";
36-
public const string Endpoints = "endpoints";
3729
}
3830
}

src/Authentication/Extensions/HttpContextExtension.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,15 @@ public static List<string> GetValidEndpoints(this HttpContext httpcontext, List<
3232
Guard.Against.Null(adminClaims);
3333
Guard.Against.Null(userClaims);
3434

35-
foreach (var claim in adminClaims)
35+
foreach (var claim in adminClaims!)
3636
{
3737
if (httpcontext.User.HasClaim(AuthKeys.UserRoles, claim.UserRoles!))
3838
{
3939
return new List<string> { "all" };
4040
}
4141
}
4242

43-
foreach (var claim in userClaims)
43+
foreach (var claim in userClaims!)
4444
{
4545
if (httpcontext.User.HasClaim(AuthKeys.UserRoles, claim.UserRoles!))
4646
{

src/Authentication/Extensions/MonaiAuthenticationExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ public static IServiceCollection AddMonaiAuthentication(
6464
{
6565
IssuerSigningKey = new SymmetricSecurityKey(Encoding.UTF8.GetBytes(configurations.Value.OpenId!.ServerRealmKey!)),
6666
ValidIssuer = configurations.Value.OpenId.ServerRealm,
67-
ValidAudiences = new List<string>() { "account", "monai-app" },
67+
ValidAudiences = configurations.Value.OpenId.Audiences,
6868
ValidateIssuerSigningKey = true,
6969
ValidateIssuer = true,
7070
ValidateLifetime = true,

src/Authentication/Tests/EndpointAuthorizationMiddlewareTest.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ public async Task GivenConfigurationFileWithOpenIdConfigured_WhenUserIsAuthentic
8484

8585
var data = await responseMessage.Content.ReadFromJsonAsync<List<string>>().ConfigureAwait(false);
8686

87+
Assert.NotNull(data);
8788
Assert.Collection(data,
8889
item => item.Equals("A", StringComparison.Ordinal),
8990
item => item.Equals("B", StringComparison.Ordinal),

src/Authentication/Tests/Monai.Deploy.Security.Authentication.Tests.csproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,13 @@
1111
<ItemGroup>
1212
<PackageReference Include="Microsoft.AspNetCore.TestHost" Version="6.0.11" />
1313
<PackageReference Include="Microsoft.Extensions.Hosting" Version="6.0.1" />
14-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.1.0" />
15-
<PackageReference Include="xunit" Version="2.4.1" />
16-
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.3">
14+
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.4.0" />
15+
<PackageReference Include="xunit" Version="2.4.2" />
16+
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
1717
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
1818
<PrivateAssets>all</PrivateAssets>
1919
</PackageReference>
20-
<PackageReference Include="coverlet.collector" Version="3.1.2">
20+
<PackageReference Include="coverlet.collector" Version="3.2.0">
2121
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
2222
<PrivateAssets>all</PrivateAssets>
2323
</PackageReference>

src/Authentication/Tests/test.auth.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
"OpenId": {
55
"ServerRealm": "TEST-REALM",
66
"ServerRealmKey": "l9ZRlbMQBt9k1klUUrlWFuke8WbqnEde",
7+
"Audiences": [ "monai-app" ],
78
"ClientId": "monai-app-test",
89
"Claims": {
910
"RequiredUserClaims": [

src/Authentication/example.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
"ServerRealm": "TEST-REALM",
66
"ServerRealmKey": "EncryptionKey",
77
"ClientId": "monai-app",
8+
"Audiences": [ "monai-deploy" ],
89
"Claims": {
910
"RequiredUserClaims": [
1011
{

0 commit comments

Comments
 (0)