Skip to content

Commit 682dcec

Browse files
committed
fix for basic auth
Signed-off-by: Neil South <neil.south@answerdigital.com>
1 parent d1936af commit 682dcec

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

src/Authentication/Middleware/BasicAuthorizationMiddleware.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,8 @@ public BasicAuthorizationMiddleware(
4949
public async Task InvokeAsync(HttpContext httpContext)
5050
{
5151

52-
if (_options.Value.BasicAuthEnabled(_logger) is false)
52+
if ((_options.Value.BypassAuthentication.HasValue && _options.Value.BypassAuthentication.Value is true)
53+
|| _options.Value.BasicAuthEnabled(_logger) is false)
5354
{
5455
await _next(httpContext).ConfigureAwait(false);
5556
return;
@@ -70,6 +71,7 @@ public async Task InvokeAsync(HttpContext httpContext)
7071
var identity = new ClaimsIdentity(claims, "Basic");
7172
var claimsPrincipal = new ClaimsPrincipal(identity);
7273
httpContext.User = claimsPrincipal;
74+
await _next(httpContext).ConfigureAwait(false);
7375
return;
7476
}
7577
}

src/Authentication/Tests/EndpointAuthorizationMiddlewareTest.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,7 @@ public async Task GivenConfigurationFileWithBasicConfigured_WhenUserIsAuthentica
165165

166166
Assert.Equal(HttpStatusCode.OK, responseMessage.StatusCode);
167167
}
168+
168169
[Fact]
169170
public async Task GivenConfigurationFileWithBasicConfigured_WhenHeaderIsInvalid_ExpectToDenyRequest()
170171
{

0 commit comments

Comments
 (0)