Skip to content

Commit f5dd6e8

Browse files
committed
Remove references to separate preview extension
1 parent db72c2e commit f5dd6e8

File tree

4 files changed

+5
-14
lines changed

4 files changed

+5
-14
lines changed

CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -854,7 +854,7 @@ major update.
854854

855855
These major updates have also been tested over the last 6 months, in 13 releases of our
856856
[PowerShell Preview extension for Visual Studio
857-
Code](https://marketplace.visualstudio.com/items?itemName=ms-vscode.PowerShell-preview). A
857+
Code](https://marketplace.visualstudio.com/items?itemName=ms-vscode.powershell). A
858858
huge thank you to all of the community members who have tested these changes to the
859859
extension and have worked with us to polish the extension before releasing it through our
860860
stable channel.
@@ -1079,7 +1079,7 @@ are updating the stable extension to bring some bug fixes forward. Please try ou
10791079
[PowerShell Preview extension][] for the latest and hopefully greatest experience, and
10801080
help us squash those bugs!
10811081

1082-
[PowerShell Preview extension]: https://marketplace.visualstudio.com/items?itemName=ms-vscode.PowerShell-Preview
1082+
[PowerShell Preview extension]: https://marketplace.visualstudio.com/items?itemName=ms-vscode.powershell
10831083

10841084
#### [PowerShellEditorServices](https://github.com/PowerShell/PowerShellEditorServices)
10851085

extension-dev.code-workspace

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"josefpihrt-vscode.roslynator",
1818
"ms-azure-devops.azure-pipelines",
1919
"ms-dotnettools.csharp",
20-
"ms-vscode.powershell-preview"
20+
"ms-vscode.powershell"
2121
]
2222
},
2323
"settings": {

src/features/ExternalApi.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,8 @@ export class ExternalApiFeature extends LanguageClientConsumer implements IPower
7272
throw new Error(`No extension installed with id '${id}'. You must use a valid extension id.`);
7373
}
7474

75-
// These are only allowed to be used in our unit tests.
76-
if ((id === "ms-vscode.powershell" || id === "ms-vscode.powershell-preview")
77-
&& !(this.extensionContext.extensionMode === vscode.ExtensionMode.Test)) {
75+
// Our ID is only only allowed to be used in our unit tests.
76+
if (id === "ms-vscode.powershell" && !(this.extensionContext.extensionMode === vscode.ExtensionMode.Test)) {
7877
throw new Error("You can't use the PowerShell extension's id in this registration.");
7978
}
8079

src/main.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -56,14 +56,6 @@ export async function activate(context: vscode.ExtensionContext): Promise<IPower
5656

5757
telemetryReporter = new TelemetryReporter(PackageJSON.name, PackageJSON.version, AI_KEY);
5858

59-
// If both extensions are enabled, this will cause unexpected behavior since both register the same commands.
60-
// TODO: Merge extensions and use preview channel in marketplace instead.
61-
if (PackageJSON.name.toLowerCase() === "powershell-preview"
62-
&& vscode.extensions.getExtension("ms-vscode.powershell")) {
63-
void logger.writeAndShowError(
64-
"'PowerShell' and 'PowerShell Preview' are both enabled. Please disable one for best performance.");
65-
}
66-
6759
// Load and validate settings (will prompt for 'cwd' if necessary).
6860
await validateCwdSetting(logger);
6961
const settings = getSettings();

0 commit comments

Comments
 (0)