re-add powerShellExePath to package.json so vscode api can update it and remove references to developer.powerShellExePath

Author: TylerLeonhardt

package.json

@@ -526,6 +526,12 @@
           "type": "string",
           "description": "Specifies the PowerShell version name, as displayed by the 'PowerShell: Show Session Menu' command, used when the extension loads e.g \"Windows PowerShell (x86)\" or \"PowerShell Core 6 (x64)\". You can specify additional PowerShell executables by using the \"powershell.powerShellAdditionalExePaths\" setting."
         },
+        "powershell.powerShellExePath": {
+          "type": "string",
+          "default": "",
+          "scope": "machine",
+          "description": "REMOVED. Please use the \"powershell.powerShellDefaultVersion\" setting instead."
+        },
         "powershell.promptToUpdatePowerShell": {
           "type": "boolean",
           "description": "Specifies whether you should be prompted to update your version of PowerShell.",

src/session.ts

@@ -304,11 +304,6 @@ export class SessionManager implements Middleware {
             this.suppressRestartPrompt = true;
             try {
                 await Settings.change("powerShellExePath", undefined, true);
-
-                // This has been deprecated for a while so siliently remove it if it's there.
-                if (this.sessionSettings.developer.powerShellExePath) {
-                    await Settings.change("developer.powerShellExePath", undefined, true);
-                }
             } finally {
                 this.suppressRestartPrompt = false;
             }

src/settings.ts

@@ -70,7 +70,6 @@ export interface IDebuggingSettings {
 export interface IDeveloperSettings {
     featureFlags?: string[];
     // This setting is no longer used but is here to assist in cleaning up the users settings.
-    powerShellExePath?: string;
     bundledModulesPath?: string;
     editorServicesLogLevel?: string;
     editorServicesWaitForDebugger?: boolean;
@@ -123,7 +122,6 @@ export function load(): ISettings {
 
     const defaultDeveloperSettings: IDeveloperSettings = {
         featureFlags: [],
-        powerShellExePath: undefined,
         bundledModulesPath: "../../../PowerShellEditorServices/module",
         editorServicesLogLevel: "Normal",
         editorServicesWaitForDebugger: false,