Skip to content

Commit 1a31f5f

Browse files
committed
Remove useless check in HelpCompletion.ts
1 parent d74b328 commit 1a31f5f

File tree

2 files changed

+3
-10
lines changed

2 files changed

+3
-10
lines changed

src/features/HelpCompletion.ts

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import {
77
} from "vscode";
88
import { RequestType } from "vscode-languageclient";
99
import { LanguageClient } from "vscode-languageclient/node";
10-
import { Logger } from "../logging";
1110
import Settings = require("../settings");
1211
import { LanguageClientConsumer } from "../languageClientConsumer";
1312

@@ -30,7 +29,7 @@ export class HelpCompletionFeature extends LanguageClientConsumer {
3029
private disposable: Disposable | undefined;
3130
private settings: Settings.ISettings;
3231

33-
constructor(private log: Logger) {
32+
constructor() {
3433
super();
3534
this.settings = Settings.load();
3635

@@ -57,19 +56,13 @@ export class HelpCompletionFeature extends LanguageClientConsumer {
5756
return;
5857
}
5958

60-
if (changeEvent.contentChanges.length === 0) {
61-
this.log.writeWarning(`<${HelpCompletionFeature.name}>: ` +
62-
`Bad TextDocumentChangeEvent message: ${JSON.stringify(changeEvent)}`);
63-
return;
64-
}
65-
6659
if (changeEvent.contentChanges.length > 0) {
6760
this.helpCompletionProvider?.updateState(
6861
changeEvent.document,
6962
changeEvent.contentChanges[0].text,
7063
changeEvent.contentChanges[0].range);
7164

72-
// todo raise an event when trigger is found, and attach complete() to the event.
65+
// TODO: Raise an event when trigger is found, and attach complete() to the event.
7366
if (this.helpCompletionProvider?.triggerFound) {
7467
await this.helpCompletionProvider.complete();
7568
this.helpCompletionProvider.reset();

src/main.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ export async function activate(context: vscode.ExtensionContext): Promise<IPower
165165
new RemoteFilesFeature(),
166166
new DebugSessionFeature(context, sessionManager, logger),
167167
new PickPSHostProcessFeature(),
168-
new HelpCompletionFeature(logger),
168+
new HelpCompletionFeature(),
169169
new CustomViewsFeature(),
170170
new PickRunspaceFeature(),
171171
externalApi

0 commit comments

Comments
 (0)