Enable 'strict' TypeScript compiler option

Author: andyleejordan

src/features/Console.ts

@@ -1,8 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
-"use strict";
-
 import vscode = require("vscode");
 import { NotificationType, RequestType } from "vscode-languageclient";
 import { LanguageClient } from "vscode-languageclient/node";

src/features/DebugSession.ts

@@ -1,8 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
-"use strict";
-
 import vscode = require("vscode");
 import { CancellationToken, DebugConfiguration, DebugConfigurationProvider,
     ExtensionContext, WorkspaceFolder } from "vscode";
@@ -428,20 +426,18 @@ export class PickPSHostProcessFeature extends LanguageClientConsumer {
             pid: "current",
         }];
 
-        const hostProcesses = await this.languageClient?.sendRequest(GetPSHostProcessesRequestType, {});
-        for (const p in hostProcesses) {
-            if (hostProcesses.hasOwnProperty(p)) {
+        const response = await this.languageClient?.sendRequest(GetPSHostProcessesRequestType, {});
+        for (const process of response?.hostProcesses ?? []) {
                 let windowTitle = "";
-                if (hostProcesses[p].mainWindowTitle) {
-                    windowTitle = `, Title: ${hostProcesses[p].mainWindowTitle}`;
+                if (process.mainWindowTitle) {
+                    windowTitle = `, Title: ${process.mainWindowTitle}`;
                 }
 
                 items.push({
-                    label: hostProcesses[p].processName,
-                    description: `PID: ${hostProcesses[p].processId.toString()}${windowTitle}`,
-                    pid: hostProcesses[p].processId,
+                    label: process.processName,
+                    description: `PID: ${process.processId.toString()}${windowTitle}`,
+                    pid: process.processId,
                 });
-            }
         }
 
         if (items.length === 0) {

src/features/ExtensionCommands.ts

@@ -1,8 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
-// TODO: This file needs some TLC to use strict mode.
-
 import * as os from "os";
 import * as path from "path";
 import * as vscode from "vscode";

src/features/GetCommands.ts

@@ -139,7 +139,7 @@ class Command extends vscode.TreeItem {
         };
     }
 
-    public async getChildren(_element?): Promise<Command[]> {
+    public async getChildren(_element?: any): Promise<Command[]> {
         return [];
         // Returning an empty array because we need to return something.
     }

src/features/HelpCompletion.ts

@@ -25,7 +25,7 @@ export class HelpCompletionFeature extends LanguageClientConsumer {
 
         if (this.settings.helpCompletion !== Settings.CommentType.Disabled) {
             this.helpCompletionProvider = new HelpCompletionProvider();
-            const subscriptions = [];
+            const subscriptions: Disposable[] = [];
             workspace.onDidChangeTextDocument(this.onEvent, this, subscriptions);
             this.disposable = Disposable.from(...subscriptions);
         }

src/features/RemoteFiles.ts

@@ -60,7 +60,7 @@ export class RemoteFilesFeature extends LanguageClientConsumer {
         const remoteDocuments =
             vscode.workspace.textDocuments.filter((doc) => this.isDocumentRemote(doc));
 
-        async function innerCloseFiles() {
+        async function innerCloseFiles(): Promise<void> {
             const doc = remoteDocuments.pop();
             if (doc === undefined) {
                 return;

src/logging.ts

@@ -1,8 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
-"use strict";
-
 import utils = require("./utils");
 import os = require("os");
 import vscode = require("vscode");
@@ -135,7 +133,7 @@ export class Logger implements ILogger {
     }
 
     public async startNewLog(minimumLogLevel: string = "Normal"): Promise<void> {
-        this.MinimumLogLevel = this.logLevelNameToValue(minimumLogLevel.trim());
+        this.MinimumLogLevel = Logger.logLevelNameToValue(minimumLogLevel);
 
         this.logSessionPath =
             vscode.Uri.joinPath(
@@ -146,8 +144,9 @@ export class Logger implements ILogger {
         await vscode.workspace.fs.createDirectory(this.logSessionPath);
     }
 
-    private logLevelNameToValue(logLevelName: string): LogLevel {
-        switch (logLevelName.toLowerCase()) {
+    // TODO: Make the enum smarter about strings so this goes away.
+    public static logLevelNameToValue(logLevelName: string): LogLevel {
+        switch (logLevelName.trim().toLowerCase()) {
             case "diagnostic": return LogLevel.Diagnostic;
             case "verbose": return LogLevel.Verbose;
             case "normal": return LogLevel.Normal;

src/main.ts

@@ -1,8 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
-"use strict";
-
 import vscode = require("vscode");
 import TelemetryReporter from "@vscode/extension-telemetry";
 import { DocumentSelector } from "vscode-languageclient";
@@ -122,7 +120,7 @@ export async function activate(context: vscode.ExtensionContext): Promise<IPower
 
     // Setup the logger.
     logger = new Logger(context.globalStorageUri);
-    logger.MinimumLogLevel = LogLevel[settings.developer.editorServicesLogLevel];
+    logger.MinimumLogLevel = Logger.logLevelNameToValue(settings.developer.editorServicesLogLevel);
 
     sessionManager = new SessionManager(
         context,

src/session.ts

@@ -1,8 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
-"use strict";
-
 import net = require("net");
 import path = require("path");
 import * as semver from "semver";

src/settings.ts

@@ -1,8 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
-"use strict";
-
 import vscode = require("vscode");
 import utils = require("./utils");
 import os = require("os");

src/utils.ts

@@ -1,8 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
-"use strict";
-
 import os = require("os");
 import path = require("path");
 import vscode = require("vscode");

test/utils.ts

@@ -1,8 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
-"use strict";
-
 import * as path from "path";
 import * as vscode from "vscode";
 import { IPowerShellExtensionClient } from "../src/features/ExternalApi";

tsconfig.json

@@ -11,13 +11,7 @@
     ],
     "sourceMap": true,
     "rootDir": ".",
-    // TODO: We need to enable stricter checking...
-    // "strict": true,
-    "strictBindCallApply": true,
-    "strictFunctionTypes": true,
-    "strictNullChecks": true,
-    "strictPropertyInitialization": true,
-    "useUnknownInCatchVariables": true,
+    "strict": true,
     "noImplicitReturns": true,
     "noFallthroughCasesInSwitch": true,
     "noUnusedParameters": true