Skip to content

Commit 013c23d

Browse files
[Ignore] Update Notebook dts (#2905)
Co-authored-by: TylerLeonhardt <TylerLeonhardt@users.noreply.github.com>
1 parent 6fb3bd6 commit 013c23d

File tree

1 file changed

+2
-33
lines changed

1 file changed

+2
-33
lines changed

vscode.proposed.d.ts

Lines changed: 2 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ declare module 'vscode' {
219219
readonly viewType: string;
220220
readonly isDirty: boolean;
221221
readonly isUntitled: boolean;
222-
readonly cells: NotebookCell[];
222+
readonly cells: ReadonlyArray<NotebookCell>;
223223
languages: string[];
224224
displayOrder?: GlobPattern[];
225225
metadata: NotebookDocumentMetadata;
@@ -263,7 +263,7 @@ declare module 'vscode' {
263263
/**
264264
* The column in which this editor shows.
265265
*/
266-
viewColumn?: ViewColumn;
266+
readonly viewColumn?: ViewColumn;
267267

268268
/**
269269
* Whether the panel is active (focused by the user).
@@ -316,31 +316,6 @@ declare module 'vscode' {
316316
outputId: string;
317317
}
318318

319-
export interface NotebookOutputRenderer {
320-
/**
321-
*
322-
* @returns HTML fragment. We can probably return `CellOutput` instead of string ?
323-
*
324-
*/
325-
render(document: NotebookDocument, request: NotebookRenderRequest): string;
326-
327-
/**
328-
* Call before HTML from the renderer is executed, and will be called for
329-
* every editor associated with notebook documents where the renderer
330-
* is or was used.
331-
*
332-
* The communication object will only send and receive messages to the
333-
* render API, retrieved via `acquireNotebookRendererApi`, acquired with
334-
* this specific renderer's ID.
335-
*
336-
* If you need to keep an association between the communication object
337-
* and the document for use in the `render()` method, you can use a WeakMap.
338-
*/
339-
resolveNotebook?(document: NotebookDocument, communication: NotebookCommunication): void;
340-
341-
readonly preloads?: Uri[];
342-
}
343-
344319
export interface NotebookCellsChangeData {
345320
readonly start: number;
346321
readonly deletedCount: number;
@@ -559,12 +534,6 @@ declare module 'vscode' {
559534
kernel: NotebookKernel
560535
): Disposable;
561536

562-
export function registerNotebookOutputRenderer(
563-
id: string,
564-
outputSelector: NotebookOutputSelector,
565-
renderer: NotebookOutputRenderer
566-
): Disposable;
567-
568537
export const onDidOpenNotebookDocument: Event<NotebookDocument>;
569538
export const onDidCloseNotebookDocument: Event<NotebookDocument>;
570539
export const onDidSaveNotebookDocument: Event<NotebookDocument>;

0 commit comments

Comments
 (0)