Fix update powershell feature on windows #2325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmholt
approved these changes
Nov 25, 2019
src/features/UpdatePowerShell.ts
Outdated
| sessionManager.stop(); | ||
|
|
||
| // Invoke the MSI via cmd. | ||
| const msi = spawn("cmd", [`/S /C ${msiDownloadPath}`], { |
There was a problem hiding this comment.
Do we need to use cmd, or is there a more direct way of invoking the MSI (or is there a reason not to)?
There was a problem hiding this comment.
What about "msiexec", [ "/i", msiDownloadPath ]
There was a problem hiding this comment.
Yes! Changed to msiexec
src/features/UpdatePowerShell.ts
Outdated
|
|
||
| } else if (isMacOS) { | ||
| script = "brew cask upgrade powershell"; | ||
| let script = "brew cask upgrade powershell"; |
There was a problem hiding this comment.
Possible case for a ternary?
src/features/UpdatePowerShell.ts
Outdated
| const msi = spawn("cmd", [`/S /C ${msiDownloadPath}`], { | ||
| detached: true, | ||
| cwd: os.homedir(), | ||
| env: process.env, |
There was a problem hiding this comment.
Does spawn not pass the environment by default?
There was a problem hiding this comment.
not needed. You're right
src/features/UpdatePowerShell.ts
Outdated
| // Invoke the MSI via cmd. | ||
| const msi = spawn("cmd", [`/S /C ${msiDownloadPath}`], { | ||
| detached: true, | ||
| cwd: os.homedir(), |
There was a problem hiding this comment.
Does execution of the MSI depend on this setting?
TylerLeonhardt
force-pushed
the
fix-update-powershell-windows
branch
from
d0beab0 to
e3bff17
Compare
rjmholt
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
fixes #2323
This uses the node runtime to fetch the MSI and then uses cmd to execute the MSI. This will also stop the PSIC and then restart it when the MSI is done.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready