Throw error when Test-ModuleManifest fails in Update-ModuleManifest

Author: throwaway774

Tests/PSGetUpdateModuleManifest.Tests.ps1

@@ -686,6 +686,19 @@ Describe PowerShell.PSGet.UpdateModuleManifest -Tags 'BVT','InnerLoop' {
                                           -expectedFullyQualifiedErrorId "InvalidPackageManagementProviders,Update-ModuleManifest"
     } 
 
+    # Purpose: Validate Update-ModuleManifest will throw errors when an invalid RootModule is provided
+    #
+    # Action:
+    #      Update-ModuleManifest -RootModule [InvalidRootModule]
+    #
+    # Expected Result: Update-ModuleManifest should throw errors about the invalid RootModule
+    #
+    It UpdateModuleManifestWithInvalidRootModule {
+        New-ModuleManifest -path $script:testManifestPath
+        $RootModule = "\/"
+        AssertFullyQualifiedErrorIdEquals -scriptblock {Update-ModuleManifest -Path $script:testManifestPath -RootModule $InvalidRootModule} `
+                                          -expectedFullyQualifiedErrorId "ParameterArgumentValidationError,Update-ModuleManifest"
+    }
 
     # Purpose: Validate Update-ModuleManifest will throw errors if the original manifest fail the Test-ModuleManifest
     #
@@ -969,4 +982,23 @@ Describe PowerShell.PSGet.UpdateModuleManifest -Tags 'BVT','InnerLoop' {
         Assert ($newModuleInfo.CompatiblePSEditions -contains $CompatiblePSEditions[1]) "CompatiblePSEditions should include $($CompatiblePSEditions[1])"
     } `
     -Skip:$($PSVersionTable.PSVersion -lt '5.1.0')
-}
+
+    # Purpose : Validate Update-ModuleManifest cmdlet does not update a module manifest file with an invalid root module
+    #           on PowerShell version greater than 5.1
+    #
+    # Action:
+    #       Update-ModuleManifest -Path [Path] -RootModule "\/"
+    #
+    # Expected Result: Update-ModuleManifest shoyuld not update the field "RootModule" in module manifest file
+    #
+    It "UpdateModuleManifestWithInvalidRootModule" {
+        New-ModuleManifest -path $script:testManifestPath
+
+        $InvalidRootModule = "\/"
+        try { Update-ModuleManifest -Path $script:testManifestPath -RootModule $InvalidRootModule } catch {}
+        $newModuleInfo = Test-ModuleManifest -Path $script:testManifestPath
+
+        Assert ($newModuleInfo.RootModule -contains $InvalidRootModule -eq $False) 'Module Manifest should not contain an invalid root module'
+    }`
+    -Skip:$($PSVersionTable.PSVersion -lt '5.1.0')
+}

src/PowerShellGet/public/psgetfunctions/Update-ModuleManifest.ps1

@@ -922,7 +922,7 @@ function Update-ModuleManifest
 
             #Verify the new module manifest is valid
             $testModuleInfo = Microsoft.PowerShell.Core\Test-ModuleManifest -Path $tempPath `
-                                                                        -Verbose:$VerbosePreference `
+                                                                        -Verbose:$VerbosePreference ` -ErrorAction Stop
         }
         #Catch the exceptions from Test-ModuleManifest
         catch