From e906b7d390eaff7a17d173a2305684f782750ec3 Mon Sep 17 00:00:00 2001 From: tyleonha Date: Tue, 5 Dec 2017 21:59:52 -0800 Subject: [PATCH 1/2] catch ArgumentOutOfRange exception --- .../Workspace/ScriptRegion.cs | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/PowerShellEditorServices/Workspace/ScriptRegion.cs b/src/PowerShellEditorServices/Workspace/ScriptRegion.cs index 5775ddee6..8d19f3ea8 100644 --- a/src/PowerShellEditorServices/Workspace/ScriptRegion.cs +++ b/src/PowerShellEditorServices/Workspace/ScriptRegion.cs @@ -83,10 +83,21 @@ public sealed class ScriptRegion : IScriptExtent /// public static ScriptRegion Create(IScriptExtent scriptExtent) { + // IScriptExtent throws an ArgumentOutOfRange exception if Text is null + string scriptExtentText; + try + { + scriptExtentText = scriptExtent.Text; + } + catch (ArgumentOutOfRangeException e) + { + scriptExtentText = ""; + } + return new ScriptRegion { File = scriptExtent.File, - Text = scriptExtent.Text, + Text = scriptExtentText, StartLineNumber = scriptExtent.StartLineNumber, StartColumnNumber = scriptExtent.StartColumnNumber, StartOffset = scriptExtent.StartOffset, From 1c1f6c46063695409f4073c4be40a430f8942d9d Mon Sep 17 00:00:00 2001 From: tyleonha Date: Wed, 6 Dec 2017 13:58:25 -0800 Subject: [PATCH 2/2] "" to string.Empty --- src/PowerShellEditorServices/Workspace/ScriptRegion.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PowerShellEditorServices/Workspace/ScriptRegion.cs b/src/PowerShellEditorServices/Workspace/ScriptRegion.cs index 8d19f3ea8..ab1191d4c 100644 --- a/src/PowerShellEditorServices/Workspace/ScriptRegion.cs +++ b/src/PowerShellEditorServices/Workspace/ScriptRegion.cs @@ -91,7 +91,7 @@ public static ScriptRegion Create(IScriptExtent scriptExtent) } catch (ArgumentOutOfRangeException e) { - scriptExtentText = ""; + scriptExtentText = string.Empty; } return new ScriptRegion