Skip to content

Commit fb08b67

Browse files
committed
Ensure failed remote file saves are logged
1 parent da786c8 commit fb08b67

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

src/PowerShellEditorServices/Services/Workspace/RemoteFileManagerService.cs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -392,16 +392,16 @@ public async Task SaveRemoteFileAsync(string localFilePath)
392392
.AddParameter("RemoteFilePath", remoteFilePath)
393393
.AddParameter("Content", localFileContents);
394394

395-
await _executionService.ExecutePSCommandAsync<object>(
396-
saveCommand,
397-
CancellationToken.None).ConfigureAwait(false);
398-
399-
/*
400-
if (errorMessages.Length > 0)
395+
try
396+
{
397+
await _executionService.ExecutePSCommandAsync<object>(
398+
saveCommand,
399+
CancellationToken.None).ConfigureAwait(false);
400+
}
401+
catch (Exception e)
401402
{
402-
this.logger.LogError($"Remote file save failed due to an error:\r\n\r\n{errorMessages}");
403+
this.logger.LogError(e, "Remote file save failed");
403404
}
404-
*/
405405
}
406406

407407
/// <summary>

0 commit comments

Comments
 (0)