Fix null dereference bug in RaiseDebuggerStoppedEvent()

andyleejordan · andyleejordan · commit fa7f647d6c0c · 2021-12-20T12:08:23.000-08:00
diff --git a/src/PowerShellEditorServices/Services/PowerShell/Debugging/PowerShellDebugContext.cs b/src/PowerShellEditorServices/Services/PowerShell/Debugging/PowerShellDebugContext.cs
@@ -167,7 +167,9 @@ private void RaiseDebuggerStoppedEvent()
         {
             if (!IsDebugServerActive)
             {
-                _languageServer.SendNotification("powerShell/startDebugger");
+                // NOTE: The language server is not necessarily connected, so this must be
+                // conditional access. This shows up in unit tests.
+                _languageServer?.SendNotification("powerShell/startDebugger");
             }
 
             DebuggerStopped?.Invoke(this, LastStopEventArgs);

Original file line number	Diff line number	Diff line change
`@@ -167,7 +167,9 @@ private void RaiseDebuggerStoppedEvent()`
`167`	`167`	`{`
`168`	`168`	`if (!IsDebugServerActive)`
`169`	`169`	`{`
`170`		`- _languageServer.SendNotification("powerShell/startDebugger");`
	`170`	`+ // NOTE: The language server is not necessarily connected, so this must be`
	`171`	`+ // conditional access. This shows up in unit tests.`
	`172`	`+ _languageServer?.SendNotification("powerShell/startDebugger");`
`171`	`173`	`}`
`172`	`174`
`173`	`175`	`DebuggerStopped?.Invoke(this, LastStopEventArgs);`