fix Contains extension method for same line extent

Author: fflaten

src/PowerShellEditorServices/Services/Symbols/Vistors/FindSymbolVisitor.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
+// Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
 using System.Management.Automation.Language;
@@ -85,7 +85,7 @@ public override AstVisitAction VisitFunctionDefinition(FunctionDefinitionAst fun
                 nameExtent = VisitorUtils.GetNameExtent(functionDefinitionAst);
             }
 
-            if (IsPositionInExtent(nameExtent))
+            if (nameExtent.Contains(lineNumber, columnNumber))
             {
                 FoundSymbolReference =
                     new SymbolReference(
@@ -139,7 +139,9 @@ public override AstVisitAction VisitVariableExpression(VariableExpressionAst var
         }
 
         /// <summary>
-        /// Is the position of the given location is in the ast's extent
+        /// Is the position of the given location is in the ast's extent.
+        /// Only works with single-line extents like name extents.
+        /// Use <see cref="ObjectExtensions.Contains"/> extension for definition extents.
         /// </summary>
         /// <param name="extent">The script extent of the element</param>
         /// <returns>True if the given position is in the range of the element's extent </returns>
@@ -206,7 +208,7 @@ public override AstVisitAction VisitTypeDefinition(TypeDefinitionAst typeDefinit
                 nameExtent = VisitorUtils.GetNameExtent(typeDefinitionAst);
             }
 
-            if (IsPositionInExtent(nameExtent))
+            if (nameExtent.Contains(lineNumber, columnNumber))
             {
                 SymbolType symbolType =
                     typeDefinitionAst.IsEnum ?

src/PowerShellEditorServices/Utility/Extensions.cs

@@ -135,7 +135,14 @@ public static bool Contains(this IScriptExtent scriptExtent, int line, int colum
 
             if (scriptExtent.StartLineNumber == line)
             {
-                return scriptExtent.StartColumnNumber <= column;
+                if (scriptExtent.StartLineNumber == scriptExtent.EndLineNumber)
+                {
+                    return scriptExtent.StartColumnNumber <= column && scriptExtent.EndColumnNumber >= column;
+                }
+                else
+                {
+                    return scriptExtent.StartColumnNumber <= column;
+                }
             }
 
             if (scriptExtent.EndLineNumber == line)