d TODOS

Author: glennsarti

src/PowerShellEditorServices.Protocol/Server/LanguageServer.cs

@@ -728,6 +728,9 @@ await this.RunScriptDiagnosticsAsync(
             }
         }
 
+        // NEED TO CHECK FILE GLOBBING HERE!!
+        // This is the handler for textDocument/definition - https://microsoft.github.io/language-server-protocol/specification#textDocument_definition
+        // It searches the workspace for a function reference, which is then used as the definition
         protected async Task HandleDefinitionRequestAsync(
             TextDocumentPositionParams textDocumentPosition,
             RequestContext<Location[]> requestContext)
@@ -751,6 +754,7 @@ protected async Task HandleDefinitionRequestAsync(
                     await editorSession.LanguageService.GetDefinitionOfSymbolAsync(
                         scriptFile,
                         foundSymbol,
+                        // Probably something here...
                         editorSession.Workspace);
 
                 if (definition != null)
@@ -767,6 +771,9 @@ await editorSession.LanguageService.GetDefinitionOfSymbolAsync(
             await requestContext.SendResultAsync(definitionLocations.ToArray());
         }
 
+        // NEED TO CHECK FILE GLOBBING HERE!!
+        // This is the handler for textDocument/References - https://microsoft.github.io/language-server-protocol/specification#textDocument_references
+        // It searches the workspace for a function reference
         protected async Task HandleReferencesRequestAsync(
             ReferencesParams referencesParams,
             RequestContext<Location[]> requestContext)
@@ -784,7 +791,9 @@ protected async Task HandleReferencesRequestAsync(
             FindReferencesResult referencesResult =
                 await editorSession.LanguageService.FindReferencesOfSymbolAsync(
                     foundSymbol,
+                    // Probably something here...
                     editorSession.Workspace.ExpandScriptReferences(scriptFile),
+                    // Probably something here...
                     editorSession.Workspace);
 
             Location[] referenceLocations = s_emptyLocationResult;

src/PowerShellEditorServices/Language/LanguageService.cs

@@ -337,6 +337,7 @@ public async Task<FindReferencesResult> FindReferencesOfSymbolAsync(
                 fileMap[scriptFile.FilePath] = scriptFile;
             }
 
+            // Probably something here...
             foreach (string filePath in workspace.EnumeratePSFiles())
             {
                 if (!fileMap.Contains(filePath))
@@ -451,6 +452,7 @@ public async Task<GetDefinitionResult> GetDefinitionOfSymbolAsync(
             if (foundDefinition == null)
             {
                 // Get a list of all powershell files in the workspace path
+                // Probably something here...
                 IEnumerable<string> allFiles = workspace.EnumeratePSFiles();
                 foreach (string file in allFiles)
                 {

src/PowerShellEditorServices/Workspace/Workspace.cs

@@ -265,6 +265,7 @@ public void CloseFile(ScriptFile scriptFile)
         /// in the array is the "root file" of the search</returns>
         public ScriptFile[] ExpandScriptReferences(ScriptFile scriptFile)
         {
+// TODO: This should probably honor the files.exclude
             Dictionary<string, ScriptFile> referencedScriptFiles = new Dictionary<string, ScriptFile>();
             List<ScriptFile> expandedReferences = new List<ScriptFile>();