Skip to content

Commit 73f157b

Browse files
Kapil Borledaviwil
Kapil Borle
authored andcommitted
Fix definition request parameter
1 parent 81d570f commit 73f157b

File tree

3 files changed

+19
-10
lines changed

3 files changed

+19
-10
lines changed

src/PowerShellEditorServices.Protocol/LanguageServer/Definition.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ namespace Microsoft.PowerShell.EditorServices.Protocol.LanguageServer
1010
public class DefinitionRequest
1111
{
1212
public static readonly
13-
RequestType<TextDocumentPosition, Location[], object, TextDocumentRegistrationOptions> Type =
14-
RequestType<TextDocumentPosition, Location[], object, TextDocumentRegistrationOptions>.Create("textDocument/definition");
13+
RequestType<TextDocumentPositionParams, Location[], object, TextDocumentRegistrationOptions> Type =
14+
RequestType<TextDocumentPositionParams, Location[], object, TextDocumentRegistrationOptions>.Create("textDocument/definition");
1515
}
1616
}
1717

src/PowerShellEditorServices.Protocol/Server/LanguageServer.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -624,12 +624,12 @@ await this.RunScriptDiagnostics(
624624
}
625625

626626
protected async Task HandleDefinitionRequest(
627-
TextDocumentPosition textDocumentPosition,
627+
TextDocumentPositionParams textDocumentPosition,
628628
RequestContext<Location[]> requestContext)
629629
{
630630
ScriptFile scriptFile =
631631
editorSession.Workspace.GetFile(
632-
textDocumentPosition.Uri);
632+
textDocumentPosition.TextDocument.Uri);
633633

634634
SymbolReference foundSymbol =
635635
editorSession.LanguageService.FindSymbolAtLocation(

test/PowerShellEditorServices.Test.Host/LanguageServerTests.cs

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -370,9 +370,12 @@ public async Task FindsDefinitionOfCommand()
370370
Location[] locations =
371371
await this.SendRequest(
372372
DefinitionRequest.Type,
373-
new TextDocumentPosition
373+
new TextDocumentPositionParams
374374
{
375-
Uri = "TestFiles\\FindReferences.ps1",
375+
TextDocument = new TextDocumentIdentifier
376+
{
377+
Uri = "TestFiles\\FindReferences.ps1",
378+
},
376379
Position = new Position
377380
{
378381
Line = 2,
@@ -394,9 +397,12 @@ public async Task FindsNoDefinitionOfBuiltinCommand()
394397
Location[] locations =
395398
await this.SendRequest(
396399
DefinitionRequest.Type,
397-
new TextDocumentPosition
400+
new TextDocumentPositionParams
398401
{
399-
Uri = "TestFiles\\FindReferences.ps1",
402+
TextDocument = new TextDocumentIdentifier
403+
{
404+
Uri = "TestFiles\\FindReferences.ps1"
405+
},
400406
Position = new Position
401407
{
402408
Line = 10,
@@ -416,9 +422,12 @@ public async Task FindsDefintionOfVariable()
416422
Location[] locations =
417423
await this.SendRequest(
418424
DefinitionRequest.Type,
419-
new TextDocumentPosition
425+
new TextDocumentPositionParams
420426
{
421-
Uri = "TestFiles\\FindReferences.ps1",
427+
TextDocument = new TextDocumentIdentifier
428+
{
429+
Uri = "TestFiles\\FindReferences.ps1"
430+
},
422431
Position = new Position
423432
{
424433
Line = 8,

0 commit comments

Comments
 (0)