Skip to content

Commit ffac5df

Browse files
JamesWTruheradityapatwardhan
authored andcommitted
Change long to int64_t in common stat struct (#42)
1 parent 75176eb commit ffac5df

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

src/libpsl-native/src/getcommonstat.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,16 @@ PAL_BEGIN_EXTERNC
1111

1212
struct CommonStat
1313
{
14-
long Inode;
14+
int64_t Inode;
1515
int Mode;
1616
int UserId;
1717
int GroupId;
1818
int HardlinkCount;
19-
long Size;
20-
long AccessTime;
21-
long ModifiedTime;
22-
long ChangeTime;
23-
long BlockSize;
19+
int64_t Size;
20+
int64_t AccessTime;
21+
int64_t ModifiedTime;
22+
int64_t ChangeTime;
23+
int64_t BlockSize;
2424
int DeviceId;
2525
int NumberOfBlocks;
2626
int IsDirectory;

src/libpsl-native/test/test-getcommonstat.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -274,6 +274,7 @@ TEST(GetCommonStat, Mode002)
274274
GetCommonStat(fname, &cs);
275275
unlink(fname);
276276
EXPECT_EQ(cs.Mode, buffer.st_mode);
277+
EXPECT_EQ(cs.IsSetUid, 1);
277278
}
278279

279280
TEST(GetCommonStat, Mode003)
@@ -291,6 +292,7 @@ TEST(GetCommonStat, Mode003)
291292
GetCommonStat(fname, &cs);
292293
unlink(fname);
293294
EXPECT_EQ(cs.Mode, buffer.st_mode);
295+
// don't check for IsSetGid as that can vary from platform based on file system
294296
}
295297

296298
TEST(GetCommonStat, Mode004)
@@ -308,5 +310,6 @@ TEST(GetCommonStat, Mode004)
308310
GetCommonStat(dname, &cs);
309311
rmdir(dname);
310312
EXPECT_EQ(cs.Mode, buffer.st_mode);
313+
EXPECT_EQ(cs.IsSticky, 1);
311314
}
312315

0 commit comments

Comments
 (0)