From 6c9b9cfadd1fa954f57026855f4a3c199947f6a6 Mon Sep 17 00:00:00 2001
From: quoctruong <quoct@microsoft.com>
Date: Fri, 22 May 2015 19:17:54 -0700
Subject: [PATCH] Fix AvoidUsingPlainTextForPassword raised for types other
 than strings or object

---
 Rules/AvoidUsingPlainTextForPassword.cs                    | 4 ++--
 Tests/Rules/AvoidUsingPlainTextForPasswordNoViolations.ps1 | 3 ++-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/Rules/AvoidUsingPlainTextForPassword.cs b/Rules/AvoidUsingPlainTextForPassword.cs
index a4f6e0d9d..9cc2e1171 100644
--- a/Rules/AvoidUsingPlainTextForPassword.cs
+++ b/Rules/AvoidUsingPlainTextForPassword.cs
@@ -55,8 +55,8 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)
                     }
                 }
 
-                if (hasPwd && (!paramType.IsArray && paramType != typeof(System.Security.SecureString)
-                              || (paramType.IsArray && paramType.GetElementType() != typeof(System.Security.SecureString))))
+                if (hasPwd && (!paramType.IsArray && (paramType == typeof(String) || paramType == typeof(object)))
+                              || (paramType.IsArray && (paramType.GetElementType() == typeof(String) || paramType.GetElementType() == typeof(object))))
                 {
                     yield return new DiagnosticRecord(
                         String.Format(CultureInfo.CurrentCulture, Strings.AvoidUsingPlainTextForPasswordError, paramAst.Name),
diff --git a/Tests/Rules/AvoidUsingPlainTextForPasswordNoViolations.ps1 b/Tests/Rules/AvoidUsingPlainTextForPasswordNoViolations.ps1
index a4e84f4b9..3203dc0f4 100644
--- a/Tests/Rules/AvoidUsingPlainTextForPasswordNoViolations.ps1
+++ b/Tests/Rules/AvoidUsingPlainTextForPasswordNoViolations.ps1
@@ -10,7 +10,8 @@
                    ValueFromPipelineByPropertyName=$true,
                    Position=0)]
         $Param1,
-
+        [int]
+        $passwordinteger,
         # Param2 help description
         [int]
         $Param2,