More robust PSProvideDefaultParameterValue tests

Author: GoodOlClint

Tests/Rules/ProvideDefaultParameterValue.ps1

@@ -1,10 +1,14 @@
 function BadFunc
 {
     param(
-        [Parameter()]
+        [Parameter(Mandatory=$true)]
         [ValidateNotNullOrEmpty()]    
         [string]
-        $Param1
+        $Param1,
+        [Parameter(Mandatory=$false)]
+        [ValidateNotNullOrEmpty()]    
+        [string]
+        $Param2
     )
     $Param1
     $Param1 = "test"

Tests/Rules/ProvideDefaultParameterValue.tests.ps1

@@ -1,6 +1,6 @@
 Import-Module PSScriptAnalyzer
 $violationName = "PSProvideDefaultParameterValue"
-$violationMessage = "Parameter 'Param1' is not initialized. Parameters must have a default value. To fix a violation of this rule, please specify a default value for all parameters"
+$violationMessage = "Parameter 'Param2' is not initialized. Parameters must have a default value. To fix a violation of this rule, please specify a default value for all parameters"
 $directory = Split-Path -Parent $MyInvocation.MyCommand.Path
 $violations = Invoke-ScriptAnalyzer $directory\ProvideDefaultParameterValue.ps1 | Where-Object {$_.RuleName -match $violationName}
 $noViolations = Invoke-ScriptAnalyzer $directory\ProvideDefaultParameterValueNoViolations.ps1

Tests/Rules/ProvideDefaultParameterValueNoViolations.ps1

@@ -1,10 +1,14 @@
 function GoodFunc
 {
     param(
+        [Parameter(Mandatory=$true)]
+        [ValidateNotNullOrEmpty()]    
+        [string]
+        $Param1,
         [Parameter(Mandatory=$false)]
         [ValidateNotNullOrEmpty()]    
         [string]
-        $Param1=$null
+        $Param2=$null
     )
     $Param1
 }