Merge pull request #204 from PowerShell/FixAvoidUsingPlainTextForPassword

Fix AvoidUsingPlainTextForPassword raised for types other than strings or object

Author: Quoc Truong

Rules/AvoidUsingPlainTextForPassword.cs

@@ -55,8 +55,8 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)
                     }
                 }
 
-                if (hasPwd && (!paramType.IsArray && paramType != typeof(System.Security.SecureString)
-                              || (paramType.IsArray && paramType.GetElementType() != typeof(System.Security.SecureString))))
+                if (hasPwd && (!paramType.IsArray && (paramType == typeof(String) || paramType == typeof(object)))
+                              || (paramType.IsArray && (paramType.GetElementType() == typeof(String) || paramType.GetElementType() == typeof(object))))
                 {
                     yield return new DiagnosticRecord(
                         String.Format(CultureInfo.CurrentCulture, Strings.AvoidUsingPlainTextForPasswordError, paramAst.Name),

Tests/Rules/AvoidUsingPlainTextForPasswordNoViolations.ps1

@@ -10,7 +10,8 @@
                    ValueFromPipelineByPropertyName=$true,
                    Position=0)]
         $Param1,
-
+        [int]
+        $passwordinteger,
         # Param2 help description
         [int]
         $Param2,