Skip to content

Commit b1ca186

Browse files
kalgizSteveL-MSFT
authored andcommitted
Tests for AvoidPositionalParameters rule fixes.
1 parent b063ac9 commit b1ca186

File tree

1 file changed

+14
-12
lines changed

1 file changed

+14
-12
lines changed

Tests/Rules/AvoidPositionalParameters.tests.ps1

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -29,19 +29,21 @@ Describe "AvoidPositionalParameters" {
2929
}
3030

3131
Context "Function defined and called in script, which has 3 or more positional parameters triggers rule." {
32-
$sb=
33-
{
34-
Function Foo {
35-
param(
36-
[Parameter(Mandatory=$true,Position=1)] $A,
37-
[Parameter(Position=2)]$B,
38-
[Parameter(Position=3)]$C)
32+
It "returns avoid positional parameters violation" {
33+
$sb=
34+
{
35+
Function Foo {
36+
param(
37+
[Parameter(Mandatory=$true,Position=1)] $A,
38+
[Parameter(Position=2)]$B,
39+
[Parameter(Position=3)]$C)
40+
}
41+
Foo "a" "b" "c"
3942
}
40-
Foo "a" "b" "c"
43+
$warnings = Invoke-ScriptAnalyzer -ScriptDefinition "$sb"
44+
$warnings.Count | Should -BeGreaterThan 0
45+
$warnings.RuleName | Should -Contain "PSAvoidUsingPositionalParameters"
46+
$warnings.Message | Should -Contain "Cmdlet 'Foo' has positional parameter. Please use named parameters instead of positional parameters when calling a command."
4147
}
42-
$warnings = Invoke-ScriptAnalyzer -ScriptDefinition "$sb"
43-
$warnings.Count | Should -BeGreaterThan 0
44-
$warning.RuleName | Should -Contain "PSAvoidUsingPositionalParameters"
45-
$warnings.Message | Should -Contain "Cmdlet 'Foo' has positional parameter. Please use named parameters instead of positional parameters when calling a command."
4648
}
4749
}

0 commit comments

Comments
 (0)