Add tests for compatible syntax rule

Author: rjmholt

Rules/CompatibilityRules/UseCompatibleSyntax.cs

@@ -172,6 +172,34 @@ public IEnumerable<DiagnosticRecord> GetDiagnosticRecords()
                 return _diagnosticAccumulator;
             }
 
+            public override AstVisitAction VisitMemberExpression(MemberExpressionAst memberExpressionAst)
+            {
+                if (!_targetVersions.Contains(s_v3))
+                {
+                    return AstVisitAction.Continue;
+                }
+
+                if (!(memberExpressionAst.Member is StringConstantExpressionAst))
+                {
+                    string message = string.Format(
+                        CultureInfo.CurrentCulture,
+                        Strings.UseCompatibleSyntaxError,
+                        "dynamic member invocation",
+                        memberExpressionAst.Extent.Text,
+                        "3");
+
+                    _diagnosticAccumulator.Add(new DiagnosticRecord(
+                        message,
+                        memberExpressionAst.Extent,
+                        _rule.GetName(),
+                        _rule.Severity,
+                        _analyzedFilePath
+                    ));
+                }
+
+                return AstVisitAction.Continue;
+            }
+
             public override AstVisitAction VisitInvokeMemberExpression(InvokeMemberExpressionAst methodCallAst)
             {
                 // Look for [typename]::new(...) and [typename]::$dynamicMethodName syntax

Tests/Rules/UseCompatibleCommands.Tests.ps1

@@ -4,7 +4,6 @@
 $script:RuleName = 'PSUseCompatibleCommands'
 $script:AnyProfileConfigKey = 'AnyProfilePath'
 $script:TargetProfileConfigKey = 'TargetProfiles'
-$script:AssetDirPath = Join-Path $PSScriptRoot $script:RuleName
 
 $script:Srv2012_3_profile = 'win-8_x64_6.2.9200.0_3.0_x64_4.0.30319.42000_framework'
 $script:Srv2012r2_4_profile = 'win-8_x64_6.3.9600.0_4.0_x64_4.0.30319.42000_framework'

Tests/Rules/UseCompatibleSyntax.Tests.ps1

@@ -0,0 +1,81 @@
+$script:RuleName = 'PSUseCompatibleSyntax'
+
+$script:ScriptDefinition = @'
+class MyClass
+{
+    [string]$Hi = "Hello"
+
+    [string]GetString()
+    {
+        return $this.Hi
+    }
+}
+
+enum MyEnum
+{
+    One,
+    Two
+}
+
+$x = [MyClass]::new()
+
+$member = 'Hi'
+Write-Host $x.$member
+
+Write-Output 'Banana'
+
+$method = 'GetString'
+$x.$method()
+
+$enumVal = "One"
+[MyEnum]::$enumVal
+'@
+
+Describe "PSUseCompatibleSyntax" {
+    BeforeAll {
+        $testCases = @(
+            @{ Script = '$x = [MyClass]::new()'; Versions = @(3,4) }
+            @{ Script = '$member = "Hi"; $x.$member'; Versions = @(3) }
+            @{ Script = 'Write-Host "Banana"'; Versions = @() }
+            @{ Script = '[System.VeryInnocuousType]::RunApiMethod($obj)'; Versions = @() }
+            @{ Script = '$y.$methodWithAVeryLongName()'; Versions = @(3) }
+            @{ Script = '$typeExpression::$staticMember'; Versions = @(3) }
+            @{ Script = '$typeExpression::$dynamicStaticMethodName()'; Versions = @(3) }
+        )
+
+        # PS v3/4 won't parse classes or enums
+        if ($PSVersionTable.PSVersion.Major -ge 5)
+        {
+            $testCases += @(
+                @{ Script = "class MyClass { }"; Versions = @(3,4) }
+                @{ Script = "enum MyEnum { One; Two }"; Versions = @(3,4) }
+            )
+        }
+
+        # PS v6+ won't parse workflows
+        if ($PSVersionTable.PSVersion.Major -le 5)
+        {
+            $testCases += @(
+                @{ Script = 'workflow Banana { Do-ExpensiveCommandOnAnotherMachine -Argument "Banana" }'; Versions = @(6) }
+            )
+        }
+    }
+
+    foreach ($v in 3,4,5,6)
+    {
+        It "Finds issues for PSv$v in '<Script>'" -TestCases $testCases {
+            param([string]$Script, $Versions)
+
+            $diagnostics = Invoke-ScriptAnalyzer -ScriptDefinition $Script -IncludeRule PSUseCompatibleSyntax -Settings @{ Rules = @{ PSUseCompatibleSyntax = @{ Enable = $true; TargetVersions = @("$v.0") } } }
+
+            if ($Versions -contains $v)
+            {
+                $diagnostics.Count | Should -Be 1
+            }
+            else
+            {
+                $diagnostics.Count | Should -Be 0
+            }
+        }
+    }
+}