Trigger AvoidPositionalParameters rule for function defined and called inside a sript given as argument to Script Analyzer.

Author: kalgiz

Engine/Helper.cs

@@ -620,7 +620,7 @@ public bool IsCmdlet(CommandAst cmdAst) {
         /// Given a commandast, checks whether positional parameters are used or not.
         /// </summary>
         /// <param name="cmdAst"></param>
-        /// <param name="moreThanTwoPositional">only return true if more than three positional parameters are used</param>
+        /// <param name="moreThanTwoPositional">only return true if more than two positional parameters are used</param>
         /// <returns></returns>
         public bool PositionalParameterUsed(CommandAst cmdAst, bool moreThanTwoPositional = false)
         {
@@ -629,13 +629,18 @@ public bool PositionalParameterUsed(CommandAst cmdAst, bool moreThanTwoPositiona
                 return false;
             }
 
+<<<<<<< 29f5017120de0ccf4c9737ca8a89d50ee66b63a1
+=======
+            int parameters = 0;
+>>>>>>> Trigger AvoidPositionalParameters rule for function defined and called inside a sript given as argument to Script Analyzer.
             // Because of the way we count, we will also count the cmdlet as an argument so we have to -1
             int argumentsWithoutProcedingParameters = -1;
             bool parameterPreceding = false;
 
             foreach (CommandElementAst ceAst in cmdAst.CommandElements)
             {
                 var cmdParamAst = ceAst as CommandParameterAst;
+<<<<<<< 29f5017120de0ccf4c9737ca8a89d50ee66b63a1
                 if (cmdParamAst != null)
                 {
                     parameterPreceding = true;
@@ -646,6 +651,11 @@ public bool PositionalParameterUsed(CommandAst cmdAst, bool moreThanTwoPositiona
                         argumentsWithoutProcedingParameters += 1;
                     }
                     parameterPreceding = false;
+=======
+                if (cmdParamAst == null)
+                {
+                    arguments += 1;
+>>>>>>> Trigger AvoidPositionalParameters rule for function defined and called inside a sript given as argument to Script Analyzer.
                 }
             }
 

Rules/UseCmdletCorrectly.cs

@@ -129,7 +129,11 @@ private bool MandatoryParameterExists(CommandAst cmdAst)
                 return true;
             }
 
+<<<<<<< 29f5017120de0ccf4c9737ca8a89d50ee66b63a1
             if (mandParams.Count == 0 || (Helper.Instance.IsCmdlet(cmdAst) && Helper.Instance.PositionalParameterUsed(cmdAst)))
+=======
+            if (mandParams.Count() == 0 || (Helper.Instance.IsCmdlet(cmdAst) && Helper.Instance.PositionalParameterUsed(cmdAst)))
+>>>>>>> Trigger AvoidPositionalParameters rule for function defined and called inside a sript given as argument to Script Analyzer.
             {
                 returnValue = true;
             }