Raise PSProvideDefaultParameterValues for parameters outside a param block

GoodOlClint · GoodOlClint · commit 94dcf514edd0 · 2015-05-17T17:07:36.000-05:00
diff --git a/Rules/ProvideDefaultParameterValue.cs b/Rules/ProvideDefaultParameterValue.cs
@@ -50,6 +50,11 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)
                     paramVariables.UnionWith(funcAst.Body.ParamBlock.Parameters.Select(paramAst => paramAst.Name.VariablePath.UserPath));
                 }
 
+                if (funcAst.Parameters != null)
+                {
+                    paramVariables.UnionWith(funcAst.Parameters.Select(paramAst => paramAst.Name.VariablePath.UserPath));
+                }
+
                 // Iterates all VariableExpressionAst and check the command name.
                 foreach (VariableExpressionAst varAst in varAsts)
                 {

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,11 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)`
`50`	`50`	`paramVariables.UnionWith(funcAst.Body.ParamBlock.Parameters.Select(paramAst => paramAst.Name.VariablePath.UserPath));`
`51`	`51`	`}`
`52`	`52`
	`53`	`+ if (funcAst.Parameters != null)`
	`54`	`+ {`
	`55`	`+ paramVariables.UnionWith(funcAst.Parameters.Select(paramAst => paramAst.Name.VariablePath.UserPath));`
	`56`	`+ }`
	`57`	`+`
`53`	`58`	`// Iterates all VariableExpressionAst and check the command name.`
`54`	`59`	`foreach (VariableExpressionAst varAst in varAsts)`
`55`	`60`	`{`