give explicit error on unsupported versions of pscore and document it (#1049)

bergmeister · web-flow · commit 5b4bacbfaaf4 · 2018-08-20T22:00:38.000+01:00
diff --git a/Engine/PSScriptAnalyzer.psm1 b/Engine/PSScriptAnalyzer.psm1
@@ -13,6 +13,9 @@ $binaryModuleRoot = $PSModuleRoot
 
 if (($PSVersionTable.Keys -contains "PSEdition") -and ($PSVersionTable.PSEdition -ne 'Desktop')) {
     $binaryModuleRoot = Join-Path -Path $PSModuleRoot -ChildPath 'coreclr'
+    if ($PSVersionTable.PSVersion -lt [version]'6.0.2') {
+        throw "Minimum supported version of PSScriptAnalyzer for PowerShell Core is 6.0.2 but current version is '$($PSVersionTable.PSVersion)'. Please update PowerShell Core."
+    }
 }
 else {
     if ($PSVersionTable.PSVersion.Major -eq 3) {
diff --git a/README.md b/README.md
@@ -76,7 +76,7 @@ Exit
 #### Supported PowerShell Versions and Platforms
 
 - Windows PowerShell 3.0 or greater
-- PowerShell Core on Windows/Linux/macOS
+- PowerShell Core 6.0.2 or greater on Windows/Linux/macOS
 - Docker (tested only using Docker CE on Windows 10 1803
   - PowerShell 6 Windows Image tags using  from [microsoft/powershell](https://hub.docker.com/r/microsoft/powershell/): `nanoserver`, `6.0.2-nanoserver`, `6.0.2-nanoserver-1709`, `windowsservercore` and `6.0.2-windowsservercore`. Example (1 warning gets produced by `Save-Module` but can be ignored):
 

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,9 @@ $binaryModuleRoot = $PSModuleRoot`
`13`	`13`
`14`	`14`	`if (($PSVersionTable.Keys -contains "PSEdition") -and ($PSVersionTable.PSEdition -ne 'Desktop')) {`
`15`	`15`	`$binaryModuleRoot = Join-Path -Path $PSModuleRoot -ChildPath 'coreclr'`
	`16`	`+ if ($PSVersionTable.PSVersion -lt [version]'6.0.2') {`
	`17`	`+ throw "Minimum supported version of PSScriptAnalyzer for PowerShell Core is 6.0.2 but current version is '$($PSVersionTable.PSVersion)'. Please update PowerShell Core."`
	`18`	`+ }`
`16`	`19`	`}`
`17`	`20`	`else {`
`18`	`21`	`if ($PSVersionTable.PSVersion.Major -eq 3) {`