Fix avoiduninitializedvariable not recognizing switchparameter

Quoc Truong · Quoc Truong · commit 32e2f614b0c4 · 2015-05-19T12:23:19.000-07:00
diff --git a/Engine/VariableAnalysis.cs b/Engine/VariableAnalysis.cs
@@ -86,7 +86,7 @@ private void ProcessParameters(IEnumerable<ParameterAst> parameters)
                             type = paramAst.TypeName.GetReflectionType();
                         }
 
-                        if (String.Equals(paramAst.TypeName.FullName, "switch", StringComparison.OrdinalIgnoreCase))
+                        if (paramAst.TypeName.GetReflectionType() == typeof(System.Management.Automation.SwitchParameter))
                         {
                             isSwitchOrMandatory = true;
                         }
diff --git a/Tests/Rules/AvoidGlobalOrUnitializedVarsNoViolations.ps1 b/Tests/Rules/AvoidGlobalOrUnitializedVarsNoViolations.ps1
@@ -31,11 +31,18 @@ $proc[0]
 
 function Test-PreferenceVariable
 {
+    Param(
+        [switch]
+        $a,
+
+        [System.Management.Automation.SwitchParameter]
+        $b
+    )
 
    if (-not $PSBoundParameters.ContainsKey('Verbose')) {
        $VerbosePreference = $PSCmdlet.GetVariableValue('VerbosePreference') -as 
         [System.Management.Automation.ActionPreference]
         }
 
         $VerbosePreference
-    }
+}

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ private void ProcessParameters(IEnumerable<ParameterAst> parameters)`
`86`	`86`	`type = paramAst.TypeName.GetReflectionType();`
`87`	`87`	`}`
`88`	`88`
`89`		`- if (String.Equals(paramAst.TypeName.FullName, "switch", StringComparison.OrdinalIgnoreCase))`
	`89`	`+ if (paramAst.TypeName.GetReflectionType() == typeof(System.Management.Automation.SwitchParameter))`
`90`	`90`	`{`
`91`	`91`	`isSwitchOrMandatory = true;`
`92`	`92`	`}`