Fix crash on duplicate assembly names

Robert Holt · Robert Holt · commit 1ff4d9fe0985 · 2019-03-26T10:36:06.000-07:00
diff --git a/PSCompatibilityAnalyzer/Microsoft.PowerShell.CrossCompatibility/Utility/TypeDataConversion.cs b/PSCompatibilityAnalyzer/Microsoft.PowerShell.CrossCompatibility/Utility/TypeDataConversion.cs
@@ -62,7 +62,7 @@ public static AvailableTypeData AssembleAvailableTypes(
                 try
                 {
                     KeyValuePair<string, AssemblyData> asmData = AssembleAssembly(asm);
-                    asms.Add(asmData.Key, asmData.Value);
+                    asms[asmData.Key] = asmData.Value;
                 }
                 catch (ReflectionTypeLoadException e)
                 {

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ public static AvailableTypeData AssembleAvailableTypes(`
`62`	`62`	`try`
`63`	`63`	`{`
`64`	`64`	`KeyValuePair<string, AssemblyData> asmData = AssembleAssembly(asm);`
`65`		`- asms.Add(asmData.Key, asmData.Value);`
	`65`	`+ asms[asmData.Key] = asmData.Value;`
`66`	`66`	`}`
`67`	`67`	`catch (ReflectionTypeLoadException e)`
`68`	`68`	`{`