Merge pull request #129 from PowerShell/BugFixes

Take the AST cast error bug fix to dev branch

Author: raghushantha

Rules/AvoidUninitializedVariable.cs

@@ -50,7 +50,8 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)
                 }
             }
 
-            IEnumerable<Ast> funcAsts = ast.FindAll(item => item is FunctionDefinitionAst || item is FunctionMemberAst, true);
+            IEnumerable<Ast> funcAsts = ast.FindAll(item => item is FunctionDefinitionAst, true);
+            IEnumerable<Ast> funcMemberAsts = ast.FindAll(item => item is FunctionMemberAst, true);
 
             // Checks whether this is a dsc resource file (we don't raise this rule for get, set and test-target resource
             bool isDscResourceFile = Helper.Instance.IsDscResourceModule(fileName);
@@ -83,6 +84,23 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)
                     }
                 }
             }
+
+            foreach (FunctionMemberAst funcMemAst in funcMemberAsts)
+            {
+                // Finds all VariableExpressionAst.
+                IEnumerable<Ast> varAsts = funcMemAst.FindAll(testAst => testAst is VariableExpressionAst, true);
+
+                // Iterates all VariableExpressionAst and check the command name.
+                foreach (VariableExpressionAst varAst in varAsts)
+                {
+                    if (Helper.Instance.IsUninitialized(varAst, funcMemAst))
+                    {
+                        yield return new DiagnosticRecord(string.Format(CultureInfo.CurrentCulture, Strings.AvoidUninitializedVariableError, varAst.VariablePath.UserPath),
+                            varAst.Extent, GetName(), DiagnosticSeverity.Warning, fileName, varAst.VariablePath.UserPath);
+                    }
+                }
+
+            }
         }
 
         /// <summary>