Always display special characters (#667)

powercode · lzybkr · commit bf36369f13b7 · 2018-06-03T23:22:11.000-07:00
Many of these are behind `AltGr` and we can't reliably determine when `AltGr` is needed.
diff --git a/PSReadLine/Keys.cs b/PSReadLine/Keys.cs
@@ -551,8 +551,12 @@ internal static int GetNormalizedHashCode(this ConsoleKeyInfo obj)
 
         internal static bool ShouldInsert(this ConsoleKeyInfo key)
         {
-            if (key.KeyChar == '\0') return false;
-
+            var keyChar = key.KeyChar;
+            if (keyChar == '\0') return false;
+            foreach (char c in "`~!@#$%^&*()-_=+[{]}\\|;:'\",<.>/?") {
+                // we always want to insert chars essential to the PowerShell experience
+                if (keyChar == c) { return true; }
+            }
             if (key.Modifiers != 0)
             {
                 // We want to ignore control sequences - but distinguishing a control sequence

Original file line number	Diff line number	Diff line change
`@@ -551,8 +551,12 @@ internal static int GetNormalizedHashCode(this ConsoleKeyInfo obj)`
`551`	`551`
`552`	`552`	`internal static bool ShouldInsert(this ConsoleKeyInfo key)`
`553`	`553`	`{`
`554`		`- if (key.KeyChar == '\0') return false;`
`555`		`-`
	`554`	`+ var keyChar = key.KeyChar;`
	`555`	`+ if (keyChar == '\0') return false;`
	`556`	+ foreach (char c in "`~!@#$%^&*()-_=+[{]}\\\|;:'\",<.>/?") {
	`557`	`+ // we always want to insert chars essential to the PowerShell experience`
	`558`	`+ if (keyChar == c) { return true; }`
	`559`	`+ }`
`556`	`560`	`if (key.Modifiers != 0)`
`557`	`561`	`{`
`558`	`562`	`// We want to ignore control sequences - but distinguishing a control sequence`