Do not do local on a variable when it has not yet been declared.

MM's code to determine version does a local on $VERSION without having
first declared it. Instead it should do 'my' on it unless the variable
is defined at a distance.

    my $VERSION = ...
    # or
    local $Foo::Bar::VERSION = ...

Doing this causes this code to pass strict where it did not previously
do so.

Author: toddr

Changes

@@ -2,6 +2,7 @@ Revision history for Module-Metadata
 
 {{$NEXT}}
   - use utf8 in tests when testing non-ascii packages.
+  - Comply with strictures when trying to detect $VERSION
 
 1.000037  2019-09-07 18:32:44Z
   - add decode_pod option for automatic =encoding handling

lib/Module/Metadata.pm

@@ -685,14 +685,19 @@ sub _evaluate_version_line {
   my $self = shift;
   my( $sigil, $variable_name, $line ) = @_;
 
+  # It is not legal to do local on a variable in the local name space before it is declared.
+  my $local = ($variable_name =~ m/::/) ? 'local' : 'our';
+
   # We compile into a local sub because 'use version' would cause
   # compiletime/runtime issues with local()
   $pn++; # everybody gets their own package
   my $eval = qq{ my \$dummy = q#  Hide from _packages_inside()
     #; package Module::Metadata::_version::p${pn};
     use version;
+    no strict 'vars';
+
     sub {
-      local $sigil$variable_name;
+      $local $sigil$variable_name;
       $line;
       return \$$variable_name if defined \$$variable_name;
       return \$Module::Metadata::_version::p${pn}::$variable_name;