Added main functional tests. More to come...

Author: Geolim4

composer.json

@@ -55,5 +55,8 @@
     },
     "autoload": {
         "psr-4": { "Phpfastcache\\Bundle\\": "src/" }
+    },
+    "autoload-dev": {
+        "psr-4": { "Phpfastcache\\Bundle\\Tests\\": "tests/" }
     }
 }

phpunit.xml.dist

@@ -12,7 +12,7 @@
 
     <testsuites>
         <testsuite name="PhpfastcacheBundle Test Suite">
-            <directory>./tests</directory>
+            <directory>./Tests</directory>
         </testsuite>
     </testsuites>
 
@@ -25,7 +25,7 @@
         <whitelist>
             <directory>./</directory>
             <exclude>
-                <directory>./tests</directory>
+                <directory>./Tests</directory>
                 <directory>./vendor</directory>
             </exclude>
         </whitelist>

tests/Functional/App/Controller/CacheController.php

@@ -17,6 +17,7 @@
 
 namespace Phpfastcache\Bundle\Tests\Functional\App\Controller;
 
+use Phpfastcache\Bundle\Response\CacheableResponse;
 use Phpfastcache\Bundle\Service\Phpfastcache;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\HttpFoundation\JsonResponse;
@@ -45,18 +46,42 @@ public function index(Request $request, Phpfastcache $phpfastcache)
      * @param \Phpfastcache\Bundle\Service\Phpfastcache $phpfastcache
      * @return Response
      */
-    public function cacheMiss(Request $request, Phpfastcache $phpfastcache)
+    public function cacheTest(Request $request, Phpfastcache $phpfastcache)
     {
-        return JsonResponse::create(['result' => 'ok']);
+        $filecache = $phpfastcache->get('filecache');
+        $cacheItem = $filecache->getItem(__FUNCTION__);
+        $cacheHit = $cacheItem->isHit();
+
+        if(!$cacheHit){
+            $cacheItem->set(1337)->expiresAfter(5);
+            $filecache->save($cacheItem);
+        }
+
+        return JsonResponse::create([
+          'result' => 'ok',
+          'cache' => $cacheHit ? 'hit' : 'miss'
+        ]);
     }
 
     /**
      * @param \Symfony\Component\HttpFoundation\Request $request
      * @param \Phpfastcache\Bundle\Service\Phpfastcache $phpfastcache
      * @return Response
      */
-    public function cacheHit(Request $request, Phpfastcache $phpfastcache)
+    public function cacheHttp(Request $request, Phpfastcache $phpfastcache)
     {
-        return JsonResponse::create(['result' => 'ok']);
+        return (new CacheableResponse($phpfastcache->get('filecache'), $request))->getResponse(__FUNCTION__, 10, function () {
+            return JsonResponse::create(['result' => 'ok']);
+        });
+    }
+
+    /**
+     * @param \Symfony\Component\HttpFoundation\Request $request
+     * @param \Phpfastcache\Bundle\Service\Phpfastcache $phpfastcache
+     * @return Response
+     */
+    public function cacheError(Request $request, Phpfastcache $phpfastcache)
+    {
+        $phpfastcache->get('unexisting');
     }
 }

tests/Functional/App/Kernel.php

@@ -63,8 +63,9 @@ protected function configureContainer(ContainerBuilder $container, LoaderInterfa
     protected function configureRoutes(RouteCollectionBuilder $routes)
     {
         $routes->add('/', CacheController::class . ':index');
-        $routes->add('/cache/miss', CacheController::class . ':cacheMiss');
-        $routes->add('/cache/hit', CacheController::class . ':cacheHit');
+        $routes->add('/cache-test', CacheController::class . ':cacheTest');
+        $routes->add('/cache-error', CacheController::class . ':cacheError');
+        $routes->add('/cache-http', CacheController::class . ':cacheHttp');
     }
 
     /**

tests/Functional/App/config.yaml

@@ -12,3 +12,13 @@ framework:
 web_profiler:
     toolbar: false
     intercept_redirects: false
+
+# PhpFastCache configuration
+phpfastcache:
+    twig_driver: "filecache" # This option must be a valid declared driver, in our example: "filecache"
+    twig_block_debug: true # This option will wrap CACHE/ENDCACHE blocks with block debug as HTML comment
+    drivers:
+        filecache:
+            type: Files
+            parameters:
+                path: "%kernel.cache_dir%/phpfastcache/"

tests/Functional/IntegrationTest.php renamed to tests/Functional/MainFunctionalTest.php

@@ -18,6 +18,7 @@
 namespace Phpfastcache\Bundle\Tests\Functional;
 
 use Phpfastcache\Bundle\Tests\Functional\App\Kernel;
+use Phpfastcache\CacheManager as PhpfastcacheManager;
 use Symfony\Bundle\FrameworkBundle\Client;
 use Symfony\Bundle\FrameworkBundle\Console\Application;
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
@@ -28,34 +29,84 @@
 /**
  * Class IntegrationTest
  * @package Phpfastcache\Bundle\Tests\Functional
+ * @runInSeparateProcesses
  */
-class IntegrationTest extends WebTestCase
+class MainFunctionalTest extends WebTestCase
 {
     /** @var Client */
     private $client;
 
     protected function setUp()
     {
         $this->client = static::createClient();
+        PhpfastcacheManager::clearInstances();
     }
 
-    public function testIntegration()
+    public function testCacheMiss()
     {
-        $response = $this->profileRequest('GET', '/');
+        $response = $this->profileRequest('GET', '/cache-test');
 
         $this->assertSame(Response::HTTP_OK, $response->getStatusCode());
+        $this->assertSame('miss', \json_decode($response->getContent(), true)['cache']);
+    }
+
+    public function testCacheHit()
+    {
+        $response = $this->profileRequest('GET', '/cache-test');
+
+        $this->assertSame(Response::HTTP_OK, $response->getStatusCode());
+        $this->assertSame('hit', \json_decode($response->getContent(), true)['cache']);
+    }
+
+    public function testCacheError()
+    {
+        $response = $this->profileRequest('GET', '/cache-error');
+
+        $this->assertSame(Response::HTTP_INTERNAL_SERVER_ERROR, $response->getStatusCode());
+    }
+
+    public function testCacheHttp()
+    {
+        /**
+         * The first request should be a MISS one
+         */
+        $response = $this->profileRequest('GET', '/cache-http');
+        $this->assertSame(Response::HTTP_OK, $response->getStatusCode());
+        $etag = $response->getEtag();
+
+        /**
+         * Clear instance to avoid Phpfastcache alerts
+         * as we are in a shared process context
+         */
+        PhpfastcacheManager::clearInstances();
+
+        /**
+         * The second request should be a HIT one with a 304 response
+         */
+        $response = $this->profileRequest('GET', '/cache-http', [
+          'If-None-Match' => $etag
+        ]);
+        $this->assertSame(Response::HTTP_NOT_MODIFIED, $response->getStatusCode());
+        $this->assertSame('', trim($response->getContent()));
     }
 
     /**
      * @param string $method
      * @param string $uri
+     * @param array $headers
      * @return \Symfony\Component\HttpFoundation\Response
      */
-    private function profileRequest(string $method, string $uri): Response
+    private function profileRequest(string $method, string $uri, array $headers = []): Response
     {
         $client = $this->client;
         $client->enableProfiler();
-        $client->request($method, $uri);
+        $serverParameter = [];
+
+        foreach ($headers as $headerKey => $headerVal) {
+            $serverParameter['HTTP_' . \str_replace('-', '_', \strtoupper($headerKey))] = $headerVal;
+        }
+
+        $client->request($method, $uri, [], [], $serverParameter);
 
         return $client->getResponse();
     }