minor #3889 DX: Cleanup - remove unused variables (kubawerlos, SpacePossum)

This PR was merged into the 2.12 branch.

Discussion
----------

DX: Cleanup - remove unused variables

Commits
-------

1917dcd PhpUnitExpectationFixerTest - add case with multiple candidates
8fa9513 Cleanup - remove unused variables

Author: SpacePossum

src/Fixer/ClassNotation/ClassDefinitionFixer.php

@@ -255,9 +255,9 @@ private function fixClassyDefinitionOpenSpacing(Tokens $tokens, array $classDefI
     {
         if ($classDefInfo['anonymousClass']) {
             if (false !== $classDefInfo['implements']) {
-                $spacing = $classDefInfo['implements']['multiLine'] ? $spacing = $this->whitespacesConfig->getLineEnding() : ' ';
+                $spacing = $classDefInfo['implements']['multiLine'] ? $this->whitespacesConfig->getLineEnding() : ' ';
             } elseif (false !== $classDefInfo['extends']) {
-                $spacing = $classDefInfo['extends']['multiLine'] ? $spacing = $this->whitespacesConfig->getLineEnding() : ' ';
+                $spacing = $classDefInfo['extends']['multiLine'] ? $this->whitespacesConfig->getLineEnding() : ' ';
             } else {
                 $spacing = ' ';
             }

src/Fixer/DoctrineAnnotation/DoctrineAnnotationArrayAssignmentFixer.php

@@ -76,7 +76,7 @@ protected function createConfigurationDefinition()
     protected function fixAnnotations(Tokens $tokens)
     {
         $scopes = [];
-        foreach ($tokens as $index => $token) {
+        foreach ($tokens as $token) {
             if ($token->isType(DocLexer::T_OPEN_PARENTHESIS)) {
                 $scopes[] = 'annotation';
 

src/Fixer/PhpUnit/PhpUnitExpectationFixer.php

@@ -235,8 +235,6 @@ private function fixExpectation($tokens, $startIndex, $endIndex)
                 }
 
                 $tokens->overrideRange($argBefore, $argBefore, $tokensOverrideArgBefore);
-
-                $limit = $tokens->count();
             }
 
             $tokens[$index] = new Token([T_STRING, 'expectException']);

src/Tokenizer/Resolver/TypeShortNameResolver.php

@@ -47,7 +47,7 @@ public function resolve(Tokens $tokens, $typeName)
         // For now only support one namespace per file:
         $namespaces = $this->getNamespacesFromTokens($tokens);
         if (1 === count($namespaces)) {
-            foreach ($namespaces as $shortName => $fullName) {
+            foreach ($namespaces as $fullName) {
                 $matches = [];
                 $regex = '/^\\\\?'.preg_quote($fullName, '/').'\\\\(?P<className>.+)$/';
                 if (Preg::match($regex, $typeName, $matches)) {

src/Tokenizer/Tokens.php

@@ -1043,7 +1043,7 @@ public function setCode($code)
         $transformers->transform($this);
 
         $this->foundTokenKinds = [];
-        foreach ($this as $index => $token) {
+        foreach ($this as $token) {
             $this->registerFoundToken($token);
         }
 

tests/Fixer/PhpUnit/PhpUnitExpectationFixerTest.php

@@ -286,31 +286,40 @@ public function testMessyWhitespaces($expected, $input = null)
 
     public function provideMessyWhitespacesCases()
     {
-        return [
-            [
-                '<?php
-    final class MyTest extends \PHPUnit_Framework_TestCase
-    {
-        function testFnc()
+        $expectedTemplate =
+'
+        function testFnc%d()
         {
             aaa();
             $this->expectException(\'RuntimeException\');
             $this->expectExceptionMessage(\'msg\'/*B*/);
             $this->expectExceptionCode(/*C*/123);
             zzz();
         }
-    }',
-                '<?php
-    final class MyTest extends \PHPUnit_Framework_TestCase
-    {
-        function testFnc()
+';
+        $inputTemplate =
+'
+        function testFnc%d()
         {
             aaa();
             $this->setExpectedException(\'RuntimeException\', \'msg\'/*B*/, /*C*/123);
             zzz();
         }
-    }',
-            ],
-        ];
+'
+;
+        $input = $expected = '<?php
+    final class MyTest extends \PHPUnit_Framework_TestCase
+    {
+    ';
+
+        for ($i = 0; $i < 8; ++$i) {
+            $expected .= sprintf($expectedTemplate, $i);
+            $input .= sprintf($inputTemplate, $i);
+        }
+
+        $expected .= "\n}";
+        $input .= "\n}";
+
+        return [[$expected, $input]];
     }
 }